[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #6103: Make decimal multiplication allow precision-loss in DataFusion

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #6103:
URL: https://github.com/apache/arrow-datafusion/pull/6103#discussion_r1174659903


##########
datafusion/core/tests/sqllogictests/test_files/tpch.slt:
##########
@@ -129,7 +129,7 @@ select
     sum(l_quantity) as sum_qty,
     sum(l_extendedprice) as sum_base_price,
     sum(l_extendedprice * (1 - l_discount)) as sum_disc_price,
-    sum(cast(l_extendedprice as decimal(12,2)) * (1 - l_discount) * (1 + l_tax)) as sum_charge,
+    sum(l_extendedprice * (1 - l_discount) * (1 + l_tax)) as sum_charge,

Review Comment:
   Remove the additional cast now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org