You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Junker (JIRA)" <ji...@apache.org> on 2011/07/18 15:57:57 UTC

[jira] [Created] (HARMONY-6685) SHA1PRNG produces less optimal results

SHA1PRNG produces less optimal results
--------------------------------------

                 Key: HARMONY-6685
                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
    Affects Versions: 6.0M3
            Reporter: Mark Junker
            Priority: Minor


It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HARMONY-6685) SHA1PRNG produces less optimal results

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070056#comment-13070056 ] 

Hudson commented on HARMONY-6685:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #1026 (See [https://builds.apache.org/job/Harmony-1.5-head-linux-x86_64/1026/])
    Apply patch from HARMONY-6685 "SHA1PRNG produces less optimal"

hindessm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148459
Files : 
* /harmony/enhanced/java/trunk/classlib/modules/security/src/main/java/common/org/apache/harmony/security/provider/crypto/SHA1PRNG_SecureRandomImpl.java


> SHA1PRNG produces less optimal results
> --------------------------------------
>
>                 Key: HARMONY-6685
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M3
>            Reporter: Mark Junker
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M4, 5.0M16
>
>         Attachments: harmony-sha1prng-bug.patch
>
>
> It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HARMONY-6685) SHA1PRNG produces less optimal results

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070060#comment-13070060 ] 

Hudson commented on HARMONY-6685:
---------------------------------

Integrated in Harmony-select-1.5-head-linux-x86_64 #166 (See [https://builds.apache.org/job/Harmony-select-1.5-head-linux-x86_64/166/])
    Apply patch from HARMONY-6685 "SHA1PRNG produces less optimal"

hindessm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148459
Files : 
* /harmony/enhanced/java/trunk/classlib/modules/security/src/main/java/common/org/apache/harmony/security/provider/crypto/SHA1PRNG_SecureRandomImpl.java


> SHA1PRNG produces less optimal results
> --------------------------------------
>
>                 Key: HARMONY-6685
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M3
>            Reporter: Mark Junker
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M4, 5.0M16
>
>         Attachments: harmony-sha1prng-bug.patch
>
>
> It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HARMONY-6685) SHA1PRNG produces less optimal results

Posted by "Mark Junker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Junker updated HARMONY-6685:
---------------------------------

    Attachment: harmony-sha1prng-bug.patch

This is the patch that fixes the operator precedence problem.

> SHA1PRNG produces less optimal results
> --------------------------------------
>
>                 Key: HARMONY-6685
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M3
>            Reporter: Mark Junker
>            Priority: Minor
>         Attachments: harmony-sha1prng-bug.patch
>
>
> It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HARMONY-6685) SHA1PRNG produces less optimal results

Posted by "Mark Junker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Junker closed HARMONY-6685.
--------------------------------


Applying this patch fixed the problem. Thanks.

> SHA1PRNG produces less optimal results
> --------------------------------------
>
>                 Key: HARMONY-6685
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M3
>            Reporter: Mark Junker
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M4, 5.0M16
>
>         Attachments: harmony-sha1prng-bug.patch
>
>
> It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HARMONY-6685) SHA1PRNG produces less optimal results

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess resolved HARMONY-6685.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M16
                   6.0M4
         Assignee: Mark Hindess

Well spotted!  Thanks for the patch.

I've applied your patch to the java5 trunk at r1148459 and merged to the java6 branch at r1148509.  Please verify (by closing this JIRA) that this resolves the issue.

Regards,
 Mark.

> SHA1PRNG produces less optimal results
> --------------------------------------
>
>                 Key: HARMONY-6685
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6685
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>    Affects Versions: 6.0M3
>            Reporter: Mark Junker
>            Assignee: Mark Hindess
>            Priority: Minor
>             Fix For: 6.0M4, 5.0M16
>
>         Attachments: harmony-sha1prng-bug.patch
>
>
> It seems that a pair of parentheses are missing to get the correct operator precedence. I just stumbled upon this bug because SHA1PRNG produces different results on Android and on my Windows machine even though both use Apache Harmony for this part.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira