You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/03 06:25:43 UTC

[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #43: change go api package

kezhenxu94 commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-satellite/pull/43#discussion_r644517661



##########
File path: Makefile
##########
@@ -54,15 +54,6 @@ tools:
 deps: tools
 	$(GO_GET) -v -t -d ./...
 
-.PHONY: gen-codes
-gen-codes:
-	$(PROTOC) --version || sh tools/install_protoc.sh
-	/bin/sh tools/protocol_gen.sh
-
-.PHONY: gen-docs
-gen-docs: build
-	rm -rf $(PLUGIN_DOC_DIR)
-	$(OUT_DIR)/$(BINARY)-$(VERSION)-$(OSNAME)-$(ARCH) docs --output=$(PLUGIN_DOC_DIR)

Review comment:
       I'm not sure why you remove these 2 targets, if you do, please also remove the related files, such as `tools/protocol_gen.sh`, as it's not used and it doesn't work now since you modify the package name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org