You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/10/15 17:05:20 UTC

Review Request 26751: Add tests for external FileSystems

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26751/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-808
    https://issues.apache.org/jira/browse/FALCON-808


Repository: falcon-git


Description
-------

Check replication to *WASB* and other external file systems


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java e877803 
  falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java c16c8f4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/26751/diff/


Testing
-------

invalidCredentialsExtFS works fine
replicateToExternalFS is not properly tested


Thanks,

Ruslan Ostafiychuk


Re: Review Request 26751: Add tests for external FileSystems

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26751/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 3:35 p.m.)


Review request for Falcon.


Bugs: FALCON-808
    https://issues.apache.org/jira/browse/FALCON-808


Repository: falcon-git


Description
-------

Check replication to *WASB* and other external file systems


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java d6780f3 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/26751/diff/


Testing
-------

invalidCredentialsExtFS works fine
replicateToExternalFS is not properly tested


Thanks,

Ruslan Ostafiychuk


Re: Review Request 26751: Add tests for external FileSystems

Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26751/#review56723
-----------------------------------------------------------



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
<https://reviews.apache.org/r/26751/#comment97112>

    This variable is needed only for specific test. Why are we adding fields to BaseTestClass ?


- Raghav Gautam


On Oct. 15, 2014, 8:05 a.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26751/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 8:05 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-808
>     https://issues.apache.org/jira/browse/FALCON-808
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Check replication to *WASB* and other external file systems
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java e877803 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java c16c8f4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26751/diff/
> 
> 
> Testing
> -------
> 
> invalidCredentialsExtFS works fine
> replicateToExternalFS is not properly tested
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>