[GitHub] [arrow] pitrou commented on a change in pull request #10223: ARROW-12617: [Python] Align orc.write_table keyword order with parquet.write_table

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #10223:
URL: https://github.com/apache/arrow/pull/10223#discussion_r625118820



##########
File path: python/pyarrow/orc.py
##########
@@ -197,6 +198,13 @@ def write_table(where, table):
     table : pyarrow.lib.Table
         The table to be written into the ORC file
     """
+    if isinstance(where, Table):
+        warnings.warn(
+            "The order of the keyword arguments has changed. Pass as "

Review comment:
       "The order of arguments". Keyword arguments are unrelated.

##########
File path: python/pyarrow/orc.py
##########
@@ -197,6 +198,13 @@ def write_table(where, table):
     table : pyarrow.lib.Table
         The table to be written into the ORC file

Review comment:
       Can you reorder the docstring as well? :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org