You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "adelapena (via GitHub)" <gi...@apache.org> on 2023/06/28 11:07:45 UTC

[GitHub] [cassandra-dtest] adelapena opened a new pull request, #223: CASSANDRA-18626: Align test_large_compaction_warning with CASSANDRA-18626

adelapena opened a new pull request, #223:
URL: https://github.com/apache/cassandra-dtest/pull/223

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-dtest] driftx commented on a diff in pull request #223: CASSANDRA-18626: Align test_large_compaction_warning with CASSANDRA-18626

Posted by "driftx (via GitHub)" <gi...@apache.org>.
driftx commented on code in PR #223:
URL: https://github.com/apache/cassandra-dtest/pull/223#discussion_r1245281905


##########
compaction_test.py:
##########
@@ -346,6 +347,7 @@ def test_compaction_strategy_switching(self, strategy):
                 time.sleep(5)
                 cluster.start()
 
+    @ported_to_in_jvm('4.0')  # org.apache.cassandra.distributed.test.guardrails.GuardrailPartitionSizeTest

Review Comment:
   should this be 5.0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-dtest] adelapena commented on a diff in pull request #223: CASSANDRA-18626: Align test_large_compaction_warning with CASSANDRA-18626

Posted by "adelapena (via GitHub)" <gi...@apache.org>.
adelapena commented on code in PR #223:
URL: https://github.com/apache/cassandra-dtest/pull/223#discussion_r1245626512


##########
compaction_test.py:
##########
@@ -346,6 +347,7 @@ def test_compaction_strategy_switching(self, strategy):
                 time.sleep(5)
                 cluster.start()
 
+    @ported_to_in_jvm('4.0')  # org.apache.cassandra.distributed.test.guardrails.GuardrailPartitionSizeTest

Review Comment:
   Absolutely, it should be 5.0, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org