[GitHub] [skywalking-agent-test-tool] kezhenxu94 commented on a change in pull request #17: Fix miss `%s` bug and modify noncompliant code

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/17#discussion_r443173371



##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/exception/TagValueNotEqualsException.java
##########
@@ -32,6 +32,6 @@ public TagValueNotEqualsException(String tagKey, String expected, String actual)
 
     @Override
     public String getCauseMessage() {
-        return String.format("[tag(%s) value]: expected=>{}, actual=>{%s}\n", tagKey, expected, actual);
+        return String.format("[tag(%s) value]: expected=>{%s}, actual=>{%s}%n", tagKey, expected, actual);

Review comment:
       These conversations totally confused me, to make it clear, I think what @wu-sheng mean is that it needs a \n or %n after `expected => {%s}`, not asking replacing the %n back to \n at the end of line, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org