[GitHub] zookeeper issue #191: ZOOKEEPER-2722: fix flaky testSessionEstablishment tes...

[hanm <gi...@git.apache.org>]

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/191
  
    >> So are we saying that the watcher.waitForConnected(CONNECTION_TIMEOUT) is not working correctly? 
    
    I believe this works as expected. I don't see any of the flaky / normal test results complain about this particular check.
    
    >> Because it seems like in most of the places you've added the check
    
    The check `testConnection` is not new, it simply improves the robustness of `zk.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT)` by wrapping it with retry, as from Jenkins test log this is the place where ConnectionLossException was thrown. Internal stress test indicates this is effective. I haven't figured out what exactly caused the ConnectionLossException in `zk.create` call for this particular test...
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---