You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "fjmacagno (via GitHub)" <gi...@apache.org> on 2023/08/28 20:49:19 UTC

[GitHub] [airflow] fjmacagno opened a new issue, #33853: Include debug information in more dagbag warnings

fjmacagno opened a new issue, #33853:
URL: https://github.com/apache/airflow/issues/33853

   ### Description
   
   Add dag/file information to RemovedInAirflow3Warning, UserWarning, and AirflowProviderDeprecationWarning, so that a user can tell where to go to fix the issue.
   
   ### Use case/motivation
   
   Some of the `RemovedInAirflow3Warning`s and `UserWarning`s aren't actionable because i have no idea what dag they are referring to, such as:
   
   * `RemovedInAirflow3Warning: The use of non-json-serializable params is deprecated and will be removed in a future release`
   * `AirflowProviderDeprecationWarning: This module is deprecated. Please use airflow.providers.cncf.kubernetes.operators.pod instead.` (this one i could take an educated guess and search for `pod` imports, but many users wouldn't)
   
   
   Some, like
   
   * `UserWarning: The parameter waiter_countdown has been deprecated to standardize naming conventions.  Please use waiter_max_attempts instead.  In the future this will default to None and defer to the waiter's default value.`
   * `RemovedInAirflow3Warning: none_failed_or_skipped Trigger Rule is deprecated. Please use none_failed_min_one_success.`
   
   are ok because i can at least search our codebase for those keywords, but they would still be more fixable with debug info. 
   
   But even of those, its hard to find at times: for instance, when getting `RemovedInAirflow3Warning: airflow.operators.python.task is deprecated. Please use the following instead` there is no string i can search for without using regexes or using an IDE to find uses of the function.
   
   Unfortunately i do know this would likely be a case-by-case fix.
   
   ### Related issues
   
   Not that i could find.
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #33853: Include debug information in more dagbag warnings

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #33853:
URL: https://github.com/apache/airflow/issues/33853#issuecomment-1702986886

   Yep. Marked as "good first issue"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include debug information in more dagbag warnings [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #33853:
URL: https://github.com/apache/airflow/issues/33853#issuecomment-1789832354

   Feel free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Include debug information in more dagbag warnings [airflow]

Posted by "tsafacjo (via GitHub)" <gi...@apache.org>.
tsafacjo commented on issue #33853:
URL: https://github.com/apache/airflow/issues/33853#issuecomment-1789704543

   can I take this issue ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org