You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/01/03 13:04:28 UTC

Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55137/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, and Rohit Choudhary.


Bugs: AMBARI-19339
    https://issues.apache.org/jira/browse/AMBARI-19339


Repository: ambari


Description
-------

Minor JS and CSS changes.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 1cb1d3d 
  contrib/views/hive20/src/main/resources/ui/app/routes/query.js 699b64c 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 812ae92 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 5001c99 
  contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs d24c7d0 

Diff: https://reviews.apache.org/r/55137/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha


Re: Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55137/#review160377
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 3, 2017, 1:04 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55137/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 1:04 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19339
>     https://issues.apache.org/jira/browse/AMBARI-19339
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Minor JS and CSS changes.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js 1cb1d3d 
>   contrib/views/hive20/src/main/resources/ui/app/routes/query.js 699b64c 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 812ae92 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 5001c99 
>   contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs d24c7d0 
> 
> Diff: https://reviews.apache.org/r/55137/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>