You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2013/03/20 20:34:23 UTC

js commit: [CB-2308]: Add loaderror channel to InAppBrowser Plugin

Updated Branches:
  refs/heads/master 598bbdff9 -> c6edd5723


[CB-2308]: Add loaderror channel to InAppBrowser Plugin


Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/c6edd572
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/c6edd572
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/c6edd572

Branch: refs/heads/master
Commit: c6edd5723ad6d7b27ae12a2202feaabe737e285d
Parents: 598bbdf
Author: Ian Clelland <ic...@chromium.org>
Authored: Thu Mar 14 11:12:44 2013 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Wed Mar 20 15:33:45 2013 -0400

----------------------------------------------------------------------
 lib/common/plugin/InAppBrowser.js |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-js/blob/c6edd572/lib/common/plugin/InAppBrowser.js
----------------------------------------------------------------------
diff --git a/lib/common/plugin/InAppBrowser.js b/lib/common/plugin/InAppBrowser.js
index 400ee56..6422315 100644
--- a/lib/common/plugin/InAppBrowser.js
+++ b/lib/common/plugin/InAppBrowser.js
@@ -26,6 +26,7 @@ function InAppBrowser() {
    this.channels = {
         'loadstart': channel.create('loadstart'),
         'loadstop' : channel.create('loadstop'),
+        'loaderror' : channel.create('loaderror'),
         'exit' : channel.create('exit')
    };
 }
@@ -56,7 +57,7 @@ module.exports = function(strUrl, strWindowName, strWindowFeatures) {
     var cb = function(eventname) {
        iab._eventHandler(eventname);
     };
-    exec(cb, null, "InAppBrowser", "open", [strUrl, strWindowName, strWindowFeatures]);
+    exec(cb, cb, "InAppBrowser", "open", [strUrl, strWindowName, strWindowFeatures]);
     return iab;
 };