You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira AJISAKA (JIRA)" <ji...@apache.org> on 2015/05/18 09:26:59 UTC
[jira] [Updated] (HADOOP-10582) Fix the test case for copying to
non-existent dir in TestFsShellCopy
[ https://issues.apache.org/jira/browse/HADOOP-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akira AJISAKA updated HADOOP-10582:
-----------------------------------
Description:
In TestFsShellCopy#checkPut, there is a following code.
{code}
final Path dstPath = new Path("path");
final Path childPath = new Path(dstPath, "childPath");
...
// copy to non-existent subdir
prepPut(childPath, false, false);
checkPut(1, srcPath, dstPath, useWindowsPath);
{code}
The code expect to test the case when we put a file to non-exsistent directory. But the code delete childPath and then copy to its parent directory (dstPath).
was:
In TestFsShellCopy#prepTest, there is a following code.
{code}
final Path dstPath = new Path("path");
final Path childPath = new Path(dstPath, "childPath");
...
// copy to non-existent subdir
prepPut(childPath, false, false);
checkPut(1, srcPath, dstPath, useWindowsPath);
{code}
The code expect to test the case when we put a file to non-exsistent directory. But the code delete childPath and then copy to its parent directory (dstPath).
Summary: Fix the test case for copying to non-existent dir in TestFsShellCopy (was: TestFsShellCopy doesn't a test case which we expect)
Hadoop Flags: Reviewed
> Fix the test case for copying to non-existent dir in TestFsShellCopy
> --------------------------------------------------------------------
>
> Key: HADOOP-10582
> URL: https://issues.apache.org/jira/browse/HADOOP-10582
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Kousuke Saruta
> Assignee: Kousuke Saruta
> Priority: Minor
> Labels: BB2015-05-RFC
> Attachments: HADOOP-10582.patch
>
>
> In TestFsShellCopy#checkPut, there is a following code.
> {code}
> final Path dstPath = new Path("path");
> final Path childPath = new Path(dstPath, "childPath");
> ...
> // copy to non-existent subdir
> prepPut(childPath, false, false);
> checkPut(1, srcPath, dstPath, useWindowsPath);
> {code}
> The code expect to test the case when we put a file to non-exsistent directory. But the code delete childPath and then copy to its parent directory (dstPath).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)