[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #994: MINIFICPP-1434: Fix flaky CSite2SiteTests on macOS

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/994#discussion_r571080486



##########
File path: nanofi/tests/CSite2SiteTests.cpp
##########
@@ -166,8 +170,12 @@ void different_version_bootstrap(minifi::io::BaseStream* stream, TransferState&
   sunny_path_bootstrap(stream, transfer_state, s2s_data);
 }
 
+

Review comment:
       I don't think we need this empty line

##########
File path: nanofi/tests/CSite2SiteTests.cpp
##########
@@ -17,6 +17,7 @@
  */
 
 #include <stdlib.h>
+#include <signal.h>

Review comment:
       This should be wrapped in `#ifndef WIN32` as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org