You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by eolivelli <gi...@git.apache.org> on 2017/10/26 11:44:47 UTC
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
GitHub user eolivelli opened a pull request:
https://github.com/apache/maven-surefire/pull/168
SUREFIRE-1424 javax.transaction.TransactionManager not visible with Java9
Contents of the patch:
- drop --add-modules=java.ee.se
- add a testcase on javax.transaction.TransactionManager
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/maven-surefire SUREFIRE-1424-noaddmodules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/168.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #168
----
commit 42a8b161ebdd38837ba66be3588514df2b8c2b05
Author: Enrico Olivelli <eo...@apache.org>
Date: 2017-10-26T11:44:29Z
SUREFIRE-1424 javax.transaction.TransactionManager not visible with Java9
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 please check it out
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
I had to prefer pushing my commit regarding Jigsaw modularity supported in Surefire project because it was too big to merge after yours. Please create a new PR with your changes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
The comment `[SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9` should be in commit.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Ok will do asap
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Ok, will do this afternoon. Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 Ihave squashed the commits and reworded the commit msg.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Oh, got it, I have to run "mvn site" on the root of the project not only on maven-surefire-plugin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860059
--- Diff: maven-surefire-plugin/src/site/markdown/java9.md ---
@@ -17,15 +17,6 @@ specific language governing permissions and limitations
under the License.
-->
-Java 9 in JAVA_HOME
--- End diff --
You should bring back the history. Some users still use 2.20.1 and there was another behavior. We should add a new point for 2.21 and recommendations. Please add the list of Java API from Jira that the Oracle guy listed Maven artifacts, implementations. This is missing in Java documentation and people will needed to be announced about them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: [SUREFIRE-1424] javax.transaction.Transact...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli closed the pull request at:
https://github.com/apache/maven-surefire/pull/168
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
We need to add a new chapter on the top in https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/markdown/java9.md and add the following API. Please mention that version 2.21.0+ does not add "--add-modules java.se.ee", the user should specify dependencies with API and implementation, and that we support Jigsaw modularity as well.
Commons Annotations
javax.annotation:javax.annotation-api:1.3.1
JavaBeans Activation Framework
javax.activation:javax.activation-api:1.2.0
Java Transaction API
javax.transaction:javax.transaction-api:1.2
JAXB
javax.xml.bind:jaxb-api:2.3.0
org.glassfish.jaxb:jaxb-runtime:2.3.0 (implementation)
JAX-WS
javax.xml.ws:jaxws-api:2.3.0
com.sun.xml.ws:jaxws-rt::2.3.0 (implementation)
The source code for each of these is maintained at https://github.com/javaee .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
If you could squash these two commits in one, it would be great.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
It was done. But I don't think you can easily rebase it since some classes were deleted or methods moved.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860152
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java ---
@@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
.addGoal( "--toolchains" )
.addGoal( System.getProperty( "maven.toolchains.file" ) )
.execute( "verify" )
- .verifyErrorFree( 2 );
+ .verifyErrorFree( 1 );
--- End diff --
I have dropped tet_corba_mod.
It is not possible to have legacy "corba module" + dependency of JTA, because module java.corba require legacy transaction packages which be loaded from the JDK and so in turn this will hide the explicit dependency.
I could create one more IT only for corba
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 I have rewritten the patch and address your comment of not altering the docs.
Tell me the next step in your vision, I will be happy to move forward and finish this important task
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I will have a look. I was busy last week.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Sure, I will rebase once you merged your big changes
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Try to name the PR like this ([] brackets):
[SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I have finished my changes in master. Can you continue?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860070
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java ---
@@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
.addGoal( "--toolchains" )
.addGoal( System.getProperty( "maven.toolchains.file" ) )
.execute( "verify" )
- .verifyErrorFree( 2 );
+ .verifyErrorFree( 1 );
--- End diff --
Why it has changed from 2 to 1?
There was two tests?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
No problem, the change was minimal, I will start from scratch
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
Thx for contributing. Close this PR. It was pushed to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 I am trying to update the site, how can I rebuild the site locally ?
I am trying with "mvn site" but it fails
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@Tibor17 ok I will do this change. Will send tomorrow.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860088
--- Diff: maven-surefire-plugin/src/site/markdown/java9.md ---
@@ -17,15 +17,6 @@ specific language governing permissions and limitations
under the License.
-->
-Java 9 in JAVA_HOME
--- End diff --
will do
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request #168: [SUREFIRE-1424] javax.transaction.Transact...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r152835233
--- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java ---
@@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
.addGoal( "--toolchains" )
.addGoal( System.getProperty( "maven.toolchains.file" ) )
.execute( "verify" )
- .verifyErrorFree( 2 );
+ .verifyErrorFree( 1 );
--- End diff --
@Tibor17 do you think it has some value to have an IT for corba ? I think that the given one is already a good proof, it tests other more important modules.
Tell me, if you want I will clone this IT test only of corba
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org