You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/08 14:30:30 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1819: Seal ArrowNativeType and OffsetSizeTrait (#1028)

tustvold commented on code in PR #1819:
URL: https://github.com/apache/arrow-rs/pull/1819#discussion_r892459671


##########
arrow/src/datatypes/native.rs:
##########
@@ -19,6 +19,10 @@ use super::DataType;
 use half::f16;
 use serde_json::{Number, Value};
 
+mod private {
+    pub trait Sealed {}

Review Comment:
   I think I prefer implementing it with the rest of the implementations for the type. It makes it clearer why it is implemented, and theoretically we may macroify it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org