You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/18 02:24:50 UTC

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1786: fix: issues

LiteSun opened a new pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   fix issues according to https://github.com/apache/apisix-dashboard/pulls?q=is%3Apr+label%3A%22plugin+form%22+ comment
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615379113



##########
File path: web/src/components/Plugin/UI/cors.tsx
##########
@@ -57,9 +57,9 @@ const Cors: React.FC<Props> = ({ form }) => {
             <Select
               mode="multiple"
               optionLabelProp="label"
-              onChange={(value) => {
-                ((value as string[]).join(","));
-                if ((value as string[]).includes('*')) {
+              onChange={(value: string[]) => {
+                value.join(",")

Review comment:
       so why do we need this line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 9c6019357d69a65c45d90ebc80a8ad93d72d0c2a
   
   https://deploy-preview-1786--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1786: fix: issues

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821932710


   Please have a better title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1786: fix: issues

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 112e8c40918592639aa5d9809e6aa1fc984dc2c9
   
   https://deploy-preview-1786--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 9c6019357d69a65c45d90ebc80a8ad93d72d0c2a
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/607cdfa794778b0008e50a88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1786: fix: issues

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615341671



##########
File path: web/src/components/Plugin/UI/cors.tsx
##########
@@ -57,9 +57,9 @@ const Cors: React.FC<Props> = ({ form }) => {
             <Select
               mode="multiple"
               optionLabelProp="label"
-              onChange={(value) => {
-                ((value as string[]).join(","));
-                if ((value as string[]).includes('*')) {
+              onChange={(value: string[]) => {
+                value.join(",")

Review comment:
       `join` will return a new value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615496573



##########
File path: web/src/components/Plugin/UI/cors.tsx
##########
@@ -57,9 +57,9 @@ const Cors: React.FC<Props> = ({ form }) => {
             <Select
               mode="multiple"
               optionLabelProp="label"
-              onChange={(value) => {
-                ((value as string[]).join(","));
-                if ((value as string[]).includes('*')) {
+              onChange={(value: string[]) => {
+                value.join(",")

Review comment:
       useless code. Just removed. cc @guoqqqi 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1786: fix: issues

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 112e8c40918592639aa5d9809e6aa1fc984dc2c9
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/607b986a931a6900087e4e32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1786: fix: issues

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821920973


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@17ff973`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1786   +/-   ##
   =========================================
     Coverage          ?   72.05%           
   =========================================
     Files             ?      125           
     Lines             ?     2906           
     Branches          ?      699           
   =========================================
     Hits              ?     2094           
     Misses            ?      812           
     Partials          ?        0           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.05% <50.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | `62.96% <ø> (ø)` | |
   | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `62.50% <0.00%> (ø)` | |
   | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `83.33% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [17ff973...112e8c4](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1786: fix: historical comments issues

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821920973


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1786](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c60193) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/17ff973a66b96547c2668b91178f3976710d2eed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17ff973) will **increase** coverage by `0.24%`.
   > The diff coverage is `60.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1786      +/-   ##
   ==========================================
   + Coverage   71.79%   72.04%   +0.24%     
   ==========================================
     Files         172      126      -46     
     Lines        6035     2919    -3116     
     Branches      699      705       +6     
   ==========================================
   - Hits         4333     2103    -2230     
   + Misses       1458      816     -642     
   + Partials      244        0     -244     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `72.04% <60.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | `62.96% <ø> (ø)` | |
   | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `65.21% <0.00%> (+2.71%)` | :arrow_up: |
   | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `83.33% <100.00%> (ø)` | |
   | [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `50.46% <0.00%> (-1.50%)` | :arrow_down: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (ø)` | |
   | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | `79.41% <0.00%> (ø)` | |
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `78.75% <0.00%> (ø)` | |
   | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <0.00%> (ø)` | |
   | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `82.14% <0.00%> (ø)` | |
   | ... and [53 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [17ff973...9c60193](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org