You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nicolás Lichtmaier <ni...@reloco.com.ar> on 2004/04/03 20:55:20 UTC

Bug? Is this time string UTF-8?

In svn_cl__info_print_time() it's assumed that 
svn_time_to_human_cstring() returns a time string in UTF-8. This is not 
true. Now that subversion calls setlocale the string is in the locale's 
default encoding. And it gives an error when trying to convert that as 
if it were UTF-8. Is fixing this just removing the conversion in 
svn_time_to_human_cstring()?


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Bug? Is this time string UTF-8?

Posted by Greg Hudson <gh...@MIT.EDU>.
On Sat, 2004-04-03 at 15:55, Nicolás Lichtmaier wrote:
> In svn_cl__info_print_time() it's assumed that 
> svn_time_to_human_cstring() returns a time string in UTF-8. This is not 
> true. Now that subversion calls setlocale the string is in the locale's 
> default encoding. And it gives an error when trying to convert that as 
> if it were UTF-8. Is fixing this just removing the conversion in 
> svn_time_to_human_cstring()?

No, Subversion functions are assumed to accept and return UTF-8 strings,
with the exception of the native-to-UTF8 conversions.  So the fix would
be in svn_time_to_human_cstring().


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org