You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/15 09:59:33 UTC
Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items
not working properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20019
https://issues.apache.org/jira/browse/AMBARI-20019
Repository: ambari
Description
-------
Added condition to disable kill for a succeeded job.
Disabled kill action when the kill button is disabled.
Added tooltips for all action buttons
Added a loader icon when action request is in progress
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 2a5fc22
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e9bc44f
contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 714de66
contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js 9760ddb
contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 95d06fc
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs a4a0cc2
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs be9310e
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs eccc95d
Diff: https://reviews.apache.org/r/56701/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu
items not working properly
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/#review165679
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 15, 2017, 9:59 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56701/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 9:59 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20019
> https://issues.apache.org/jira/browse/AMBARI-20019
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added condition to disable kill for a succeeded job.
> Disabled kill action when the kill button is disabled.
> Added tooltips for all action buttons
> Added a loader icon when action request is in progress
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 2a5fc22
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e9bc44f
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 714de66
> contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js 9760ddb
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 95d06fc
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs a4a0cc2
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs be9310e
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs eccc95d
>
> Diff: https://reviews.apache.org/r/56701/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu
items not working properly
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/#review165674
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 15, 2017, 9:59 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56701/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 9:59 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20019
> https://issues.apache.org/jira/browse/AMBARI-20019
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added condition to disable kill for a succeeded job.
> Disabled kill action when the kill button is disabled.
> Added tooltips for all action buttons
> Added a loader icon when action request is in progress
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 2a5fc22
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e9bc44f
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 714de66
> contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js 9760ddb
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 95d06fc
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs a4a0cc2
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs be9310e
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs eccc95d
>
> Diff: https://reviews.apache.org/r/56701/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>