You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/31 04:16:00 UTC

[GitHub] [incubator-mxnet] wkcn opened a new pull request #19051: Call `Stop` when custom op released

wkcn opened a new pull request #19051:
URL: https://github.com/apache/incubator-mxnet/pull/19051


   ## Description ##
   Hi there,
   As title, it may fix #18789
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] wkcn closed pull request #19051: Call the function `Stop` when custom op released

Posted by GitBox <gi...@apache.org>.
wkcn closed pull request #19051:
URL: https://github.com/apache/incubator-mxnet/pull/19051


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] wkcn commented on pull request #19051: Call the function `Stop` when custom op released

Posted by GitBox <gi...@apache.org>.
wkcn commented on pull request #19051:
URL: https://github.com/apache/incubator-mxnet/pull/19051#issuecomment-683541162


   In `src/initialize.cc`,  `LibraryInitializer::atfork_prepare()` calls `CustomOperator::Get()->Stop();`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19051: Call `Stop` when custom op released

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19051:
URL: https://github.com/apache/incubator-mxnet/pull/19051#issuecomment-683539560


   Hey @wkcn , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, clang, centos-gpu, website, unix-cpu, centos-cpu, miscellaneous, windows-gpu, sanity, windows-cpu, unix-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org