You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/27 17:44:14 UTC

[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21452: Update CuratorZookeeperRepositoryTest.java

linghengqian commented on code in PR #21452:
URL: https://github.com/apache/shardingsphere/pull/21452#discussion_r1057818269


##########
mode/type/cluster/repository/provider/zookeeper-curator/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/CuratorZookeeperRepositoryTest.java:
##########
@@ -304,4 +304,12 @@ public void assertDeleteExistKey() throws Exception {
         REPOSITORY.delete("/test/children/1");
         verify(backgroundVersionable).forPath("/test/children/1");
     }
+    
+    @Test
+    public void assertUpdate() throws Exception {
+        when(existsBuilder.forPath("/test")).thenReturn(new Stat());
+        REPOSITORY.persist("/test", "value2");
+        verify(setDataBuilder).forPath("/test", "value2".getBytes(StandardCharsets.UTF_8));
+    }
+    

Review Comment:
   - What is the point of this PR? A test with the same name already exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org