You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2024/07/03 09:41:29 UTC
[PR] IGNITE-22651 Add @Nullable for NetworkMessage fields for generated classes [ignite-3]
tkalkirill opened a new pull request, #4037:
URL: https://github.com/apache/ignite-3/pull/4037
https://issues.apache.org/jira/browse/IGNITE-22651
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22651 Add @Nullable for NetworkMessage fields for generated classes [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #4037:
URL: https://github.com/apache/ignite-3/pull/4037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22651 Add @Nullable for NetworkMessage fields for generated classes [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #4037:
URL: https://github.com/apache/ignite-3/pull/4037#discussion_r1663963564
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageBuilderGenerator.java:
##########
@@ -89,19 +93,29 @@ private List<MethodSpec> generateGettersAndSetters(MessageClass message, List<Ex
for (ExecutableElement field : fields) {
String fieldName = field.getSimpleName().toString();
- TypeMirror type = field.getReturnType();
+ TypeMirror returnTypeMirror = field.getReturnType();
+ TypeName returnTypeName = TypeName.get(returnTypeMirror);
+
+ if (!isMethodReturnPrimitive(field) && isMethodReturnNullableValue(field)) {
Review Comment:
> Please use methodReturns* instead of isMethodReturn*, I struggle to read current names.
Fix it.
> It's also weird to pass field as a method, and interpret field type as a return type, but that's how javapoet works I guess?
This name was not entered by me, I will try to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22651 Add @Nullable for NetworkMessage fields for generated classes [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #4037:
URL: https://github.com/apache/ignite-3/pull/4037#discussion_r1663942527
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageBuilderGenerator.java:
##########
@@ -89,19 +93,29 @@ private List<MethodSpec> generateGettersAndSetters(MessageClass message, List<Ex
for (ExecutableElement field : fields) {
String fieldName = field.getSimpleName().toString();
- TypeMirror type = field.getReturnType();
+ TypeMirror returnTypeMirror = field.getReturnType();
+ TypeName returnTypeName = TypeName.get(returnTypeMirror);
+
+ if (!isMethodReturnPrimitive(field) && isMethodReturnNullableValue(field)) {
Review Comment:
Please use `methodReturns*` instead of `isMethodReturn*`, I struggle to read current names.
It's also weird to pass `field` as a method, and interpret field type as a return type, but that's how `javapoet` works I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org