You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/30 13:16:25 UTC

[GitHub] [pulsar-client-go] xixiss opened a new pull request #402: Add VPC（Virtual Private Cloud）support for go sdk

xixiss opened a new pull request #402:
URL: https://github.com/apache/pulsar-client-go/pull/402


   ### Motivation
   Add listenerName field in ClientOptions to support VPC（Virtual Private Cloud）net mode in cloud environment when create client.Then sdk can use vpc mode when lookup for topics.
   
   ### Modifications
   - add "listenerName" in ClientOptions
   - Add corresponding fields when lookup


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy closed pull request #402: Add VPC（Virtual Private Cloud）support for go sdk

Posted by GitBox <gi...@apache.org>.
wolfstudy closed pull request #402:
URL: https://github.com/apache/pulsar-client-go/pull/402


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #402: Add VPC（Virtual Private Cloud）support for go sdk

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #402:
URL: https://github.com/apache/pulsar-client-go/pull/402#issuecomment-775627473


   @xixiss Move this change to 0.5.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #402: Add VPC（Virtual Private Cloud）support for go sdk

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #402:
URL: https://github.com/apache/pulsar-client-go/pull/402#discussion_r572599417



##########
File path: pulsar/internal/lookup_service_test.go
##########
@@ -117,9 +117,10 @@ func TestLookupSuccess(t *testing.T) {
 
 		expectedRequests: []pb.CommandLookupTopic{
 			{
-				RequestId:     proto.Uint64(1),
-				Topic:         proto.String("my-topic"),
-				Authoritative: proto.Bool(false),
+				RequestId:              proto.Uint64(1),
+				Topic:                  proto.String("my-topic"),
+				Authoritative:          proto.Bool(false),
+				AdvertisedListenerName: proto.String(""),

Review comment:
       @xixiss Can you add new test case for this change? This test case is used to cover other scenarios, please do not verify our own logic in this test case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org