[GitHub] barrachri commented on issue #3799: [AIRFLOW-2665] Use shlex to split args and remove shell true

[GitBox <gi...@apache.org>]

barrachri commented on issue #3799: [AIRFLOW-2665] Use shlex to split args and remove shell true
URL: https://github.com/apache/incubator-airflow/pull/3799#issuecomment-415707951
 
 
   I have a small doubt, what is the proper format of a `command`?:
   
   ```
       def execute_work(self, key, command):
           """
           Executes command received and stores result state in queue.
           :param key: the key to identify the TI
           :type key: Tuple(dag_id, task_id, execution_date)
           :param command: the command to execute
           :type command: string
           """
   ```
   because looking at the code seems should be a string...but looks like a small lie, because tests were passing a`list` (this is why I added the `isinstance` check).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services