You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/10 02:31:00 UTC
[jira] [Work logged] (AVRO-3547) support custom attribute at field level
[ https://issues.apache.org/jira/browse/AVRO-3547?focusedWorklogId=799556&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799556 ]
ASF GitHub Bot logged work on AVRO-3547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/22 02:30
Start Date: 10/Aug/22 02:30
Worklog Time Spent: 10m
Work Description: mruffing commented on PR #1736:
URL: https://github.com/apache/avro/pull/1736#issuecomment-1210078948
@nileyadav This include https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24 (introduced in this PR) breaks the API headers that are installed using the `build.sh install` script. Specifically `"../impl/json/JsonDom.hh"` is not in the include folder (generated by `build.sh install`).
Issue Time Tracking
-------------------
Worklog Id: (was: 799556)
Time Spent: 4.5h (was: 4h 20m)
> support custom attribute at field level
> ---------------------------------------
>
> Key: AVRO-3547
> URL: https://issues.apache.org/jira/browse/AVRO-3547
> Project: Apache Avro
> Issue Type: Improvement
> Components: c++
> Reporter: Nilesh Yadav
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.1, 1.12.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Custom attributes are allowed at field level as per Avro specification : [https://avro.apache.org/docs/current/spec.html#schemas|https://www.google.com/url?q=https://avro.apache.org/docs/current/spec.html%23schemas&sa=D&source=buganizer&usg=AOvVaw3JfXMgFX6Eq0Fd0TjDzgb1]
> But Avro c++ implementation does not support custom attribute at field level.
> e.g. following schema cannot be parsed correctly due to presence of "sqlName" attribute.
> {
> 'doc': 'weather warning',
> 'name': 'weather',
> 'type': 'record',
> 'fields': [
> {
> 'name': 'station',
> 'type':'string',
> 'sqlName':'abc-@12'
> },
> {
> 'name': 'time',
> 'type':'long',
> 'sqlName': '用户名'
> }]
> }
> Update implementation to support custom attribute at field level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)