You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "julianhyde (via GitHub)" <gi...@apache.org> on 2023/03/08 21:02:00 UTC

[GitHub] [calcite] julianhyde commented on pull request #3086: [CALCITE-5476] Add DATETIME_TRUNC() function (Enabled for BigQuery)

julianhyde commented on PR #3086:
URL: https://github.com/apache/calcite/pull/3086#issuecomment-1460871239

   Looks good. In a couple of places you use bigQuery terminology and refer to datetime types; can you change these to use Calcite terminology. E.g. `datetimeExpression` should be `timestamp`, and `date_time_part` should be `timeUnit`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org