[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

[GitBox <gi...@apache.org>]

surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table
URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-472193691
 
 
   Below statement is correct :
   >All segments with used = true in the metadata store (what it means today)
   
   the `is_published` col in `segments` table represents "all segments in MD store with used=1". 
   >is_published is meant to mean "has bee published to the metadata store" according to the docs.
   
   The doc [here](http://druid.io/docs/latest/querying/sql#system-schema) says above, but I think it's incomplete, as it omits the part about `used=1`.
   
   @jihoonson Did you mean to suggest that the `is_published` should include all segments from MD store (irrespective of their used flag value) ? I think we should keep the existing behavior where it only shows segments in MD store with `used=1` as I don't see any use of showing segments with `used=0`. In addition, if we enhance the behavior to also exclude overshadowed segments from this column, then I'd be okay renaming it to `is_active`, `is_queryable` or some other name we can agree on. Then the definition of this _to_be_named_ col becomes "All non-overshadowed segments in MD store with used=1". 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org