You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2011/12/07 20:05:31 UTC
Review Request: Updated libprocess (to work on Mac 10.7) and corresponding
Mesos changes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/
-----------------------------------------------------------
Review request for mesos and John Sirois.
Summary
-------
This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
This addresses bug MESOS-32.
https://issues.apache.org/jira/browse/MESOS-32
Diffs
-----
include/mesos/mesos.proto 33248ec
include/mesos/scheduler.hpp 93dda98
src/common/lock.hpp 2958752
src/common/lock.cpp 1d2118a
src/common/type_utils.hpp c0b5fe9
src/exec/exec.cpp b27c241
src/local/local.cpp 1e2273b
src/log/log.cpp 7386a9d
src/log/network.hpp c88822c
src/log/replica.cpp e60f4df
src/master/frameworks_manager.hpp bf97d5f
src/master/frameworks_manager.cpp 30fa325
src/master/http.cpp 47caf48
src/master/master.hpp fdacf36
src/master/master.cpp b6cfde7
src/master/slaves_manager.cpp 3f67aa1
src/python/native/mesos_executor_driver_impl.cpp ed4aaa5
src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
src/python/native/proxy_scheduler.cpp 934820a
src/sched/sched.cpp 7f4e980
src/slave/http.cpp 18efd8c
src/slave/reaper.hpp 63b1f5d
src/slave/reaper.cpp 4193692
src/slave/slave.hpp 37bbd8c
src/slave/slave.cpp de5716c
src/tests/exception_tests.cpp 62f4fb6
src/tests/fault_tolerance_tests.cpp ebb7709
src/tests/log_tests.cpp c6bbdd1
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
src/zookeeper/zookeeper.cpp c1aa827
third_party/libprocess/Makefile.in 6b9a095
third_party/libprocess/include/process/async.hpp 9886c3e
third_party/libprocess/include/process/dispatch.hpp 9e69896
third_party/libprocess/include/process/event.hpp PRE-CREATION
third_party/libprocess/include/process/future.hpp 52d1679
third_party/libprocess/include/process/gc.hpp d9ccb35
third_party/libprocess/include/process/latch.hpp 1f04da4
third_party/libprocess/include/process/message.hpp PRE-CREATION
third_party/libprocess/include/process/process.hpp b7d1a86
third_party/libprocess/include/process/protobuf.hpp 7636822
third_party/libprocess/include/process/run.hpp 6787f6d
third_party/libprocess/include/process/timeout.hpp 96905a8
third_party/libprocess/include/process/timer.hpp a9706aa
third_party/libprocess/src/encoder.hpp 1432aec
third_party/libprocess/src/foreach.hpp ae17f58
third_party/libprocess/src/latch.cpp 1d53246
third_party/libprocess/src/process.cpp d77b156
third_party/libprocess/src/tests.cpp b3521f3
third_party/libprocess/src/timer.cpp e9a081a
Diff: https://reviews.apache.org/r/3061/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Benjamin
Re: Review Request: Updated libprocess (to work on Mac 10.7) and
corresponding Mesos changes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/
-----------------------------------------------------------
(Updated 2012-01-26 23:05:50.785670)
Review request for mesos and John Sirois.
Changes
-------
Updated the patch to account for recent commits.
Summary
-------
This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
This addresses bugs MESOS-32 and MESOS-36.
https://issues.apache.org/jira/browse/MESOS-32
https://issues.apache.org/jira/browse/MESOS-36
Diffs (updated)
-----
include/mesos/mesos.proto cdb98ba
include/mesos/scheduler.hpp 763c634
src/common/lock.hpp 2958752
src/common/lock.cpp 1d2118a
src/common/type_utils.hpp c0b5fe9
src/exec/exec.cpp 9617423
src/local/local.cpp 1e2273b
src/log/coordinator.cpp 679fff1
src/log/log.hpp d3d6f09
src/log/log.cpp 151c46b
src/log/network.hpp 4d663a6
src/log/replica.cpp ed78f47
src/master/frameworks_manager.hpp 05c1059
src/master/frameworks_manager.cpp 6dece97
src/master/http.hpp d9fd511
src/master/http.cpp 9a8938d
src/master/master.hpp 42c812b
src/master/master.cpp b56c732
src/master/slaves_manager.hpp 3c98303
src/master/slaves_manager.cpp 28b50ef
src/python/native/mesos_executor_driver_impl.cpp d365e8f
src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
src/python/native/proxy_scheduler.cpp 934820a
src/sched/sched.cpp 347e927
src/slave/http.hpp 9e8f58f
src/slave/http.cpp 133660c
src/slave/reaper.hpp 63b1f5d
src/slave/reaper.cpp 4193692
src/slave/slave.hpp 88cfc72
src/slave/slave.cpp 62fc277
src/tests/exception_tests.cpp 2df160b
src/tests/fault_tolerance_tests.cpp db9a434
src/tests/log_tests.cpp 12cde20
src/tests/master_tests.cpp 1842def
src/tests/utils.hpp efef762
src/zookeeper/group.cpp 772ecd9
src/zookeeper/zookeeper.cpp c9c38b4
third_party/libprocess/Makefile.in 6b9a095
third_party/libprocess/include/process/async.hpp 9886c3e
third_party/libprocess/include/process/dispatch.hpp 9e69896
third_party/libprocess/include/process/future.hpp 52d1679
third_party/libprocess/include/process/gc.hpp d9ccb35
third_party/libprocess/include/process/latch.hpp 1f04da4
third_party/libprocess/include/process/process.hpp b7d1a86
third_party/libprocess/include/process/protobuf.hpp d2ac3e8
third_party/libprocess/include/process/run.hpp 6787f6d
third_party/libprocess/include/process/timer.hpp a9706aa
third_party/libprocess/src/encoder.hpp 1432aec
third_party/libprocess/src/foreach.hpp ae17f58
third_party/libprocess/src/latch.cpp 1d53246
third_party/libprocess/src/process.cpp d77b156
third_party/libprocess/src/tests.cpp b3521f3
third_party/libprocess/src/timer.cpp e9a081a
Diff: https://reviews.apache.org/r/3061/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Benjamin
Re: Review Request: Updated libprocess (to work on Mac 10.7) and
corresponding Mesos changes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/
-----------------------------------------------------------
(Updated 2011-12-21 16:07:27.783934)
Review request for mesos and John Sirois.
Changes
-------
This diff represents more update to libprocess and corresponding updates to Mesos.
Summary
-------
This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
This addresses bugs MESOS-32 and MESOS-36.
https://issues.apache.org/jira/browse/MESOS-32
https://issues.apache.org/jira/browse/MESOS-36
Diffs (updated)
-----
include/mesos/mesos.proto 33248ec
include/mesos/scheduler.hpp 93dda98
src/common/lock.hpp 2958752
src/common/lock.cpp 1d2118a
src/common/type_utils.hpp c0b5fe9
src/exec/exec.cpp b27c241
src/local/local.cpp 1e2273b
src/log/coordinator.cpp d05538d
src/log/log.hpp e50969b
src/log/log.cpp 7386a9d
src/log/network.hpp c88822c
src/log/replica.cpp e60f4df
src/master/frameworks_manager.hpp bf97d5f
src/master/frameworks_manager.cpp 30fa325
src/master/http.hpp 30ab1ff
src/master/http.cpp 47caf48
src/master/master.hpp fdacf36
src/master/master.cpp b6cfde7
src/master/slaves_manager.hpp 3c98303
src/master/slaves_manager.cpp 3f67aa1
src/python/native/mesos_executor_driver_impl.cpp ed4aaa5
src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
src/python/native/proxy_scheduler.cpp 934820a
src/sched/sched.cpp 7f4e980
src/slave/http.hpp 0b2930a
src/slave/http.cpp 18efd8c
src/slave/reaper.hpp 63b1f5d
src/slave/reaper.cpp 4193692
src/slave/slave.hpp 37bbd8c
src/slave/slave.cpp de5716c
src/tests/Makefile.in ea943f7
src/tests/exception_tests.cpp 62f4fb6
src/tests/fault_tolerance_tests.cpp ebb7709
src/tests/log_tests.cpp c6bbdd1
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
src/zookeeper/group.cpp 772ecd9
src/zookeeper/zookeeper.cpp c1aa827
third_party/libprocess/Makefile.in 6b9a095
third_party/libprocess/include/process/async.hpp 9886c3e
third_party/libprocess/include/process/clock.hpp PRE-CREATION
third_party/libprocess/include/process/defer.hpp PRE-CREATION
third_party/libprocess/include/process/deferred.hpp PRE-CREATION
third_party/libprocess/include/process/dispatch.hpp 9e69896
third_party/libprocess/include/process/event.hpp PRE-CREATION
third_party/libprocess/include/process/executor.hpp PRE-CREATION
third_party/libprocess/include/process/filter.hpp PRE-CREATION
third_party/libprocess/include/process/future.hpp 52d1679
third_party/libprocess/include/process/gc.hpp d9ccb35
third_party/libprocess/include/process/latch.hpp 1f04da4
third_party/libprocess/include/process/message.hpp PRE-CREATION
third_party/libprocess/include/process/preprocessor.hpp PRE-CREATION
third_party/libprocess/include/process/process.hpp b7d1a86
third_party/libprocess/include/process/protobuf.hpp 7636822
third_party/libprocess/include/process/run.hpp 6787f6d
third_party/libprocess/include/process/timer.hpp a9706aa
third_party/libprocess/src/encoder.hpp 1432aec
third_party/libprocess/src/foreach.hpp ae17f58
third_party/libprocess/src/latch.cpp 1d53246
third_party/libprocess/src/process.cpp d77b156
third_party/libprocess/src/tests.cpp b3521f3
third_party/libprocess/src/thread.hpp PRE-CREATION
third_party/libprocess/src/timer.cpp e9a081a
Diff: https://reviews.apache.org/r/3061/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Benjamin
Re: Review Request: Updated libprocess (to work on Mac 10.7) and
corresponding Mesos changes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2011-12-07 21:44:53, Charles Reiss wrote:
> > third_party/libprocess/src/process.cpp, line 1451
> > <https://reviews.apache.org/r/3061/diff/1/?file=62982#file62982line1451>
> >
> > pthread_create doesn't set errno.
Thanks Charles, I'll be updating the diff with this change (amongst a lot others) soon.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/#review3713
-----------------------------------------------------------
On 2011-12-07 19:06:41, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3061/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 19:06:41)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
>
>
> This addresses bugs MESOS-32 and MESOS-36.
> https://issues.apache.org/jira/browse/MESOS-32
> https://issues.apache.org/jira/browse/MESOS-36
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> include/mesos/scheduler.hpp 93dda98
> src/common/lock.hpp 2958752
> src/common/lock.cpp 1d2118a
> src/common/type_utils.hpp c0b5fe9
> src/exec/exec.cpp b27c241
> src/local/local.cpp 1e2273b
> src/log/log.cpp 7386a9d
> src/log/network.hpp c88822c
> src/log/replica.cpp e60f4df
> src/master/frameworks_manager.hpp bf97d5f
> src/master/frameworks_manager.cpp 30fa325
> src/master/http.cpp 47caf48
> src/master/master.hpp fdacf36
> src/master/master.cpp b6cfde7
> src/master/slaves_manager.cpp 3f67aa1
> src/python/native/mesos_executor_driver_impl.cpp ed4aaa5
> src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
> src/python/native/proxy_scheduler.cpp 934820a
> src/sched/sched.cpp 7f4e980
> src/slave/http.cpp 18efd8c
> src/slave/reaper.hpp 63b1f5d
> src/slave/reaper.cpp 4193692
> src/slave/slave.hpp 37bbd8c
> src/slave/slave.cpp de5716c
> src/tests/exception_tests.cpp 62f4fb6
> src/tests/fault_tolerance_tests.cpp ebb7709
> src/tests/log_tests.cpp c6bbdd1
> src/tests/master_tests.cpp 2438114
> src/tests/utils.hpp 02772f7
> src/zookeeper/zookeeper.cpp c1aa827
> third_party/libprocess/Makefile.in 6b9a095
> third_party/libprocess/include/process/async.hpp 9886c3e
> third_party/libprocess/include/process/dispatch.hpp 9e69896
> third_party/libprocess/include/process/event.hpp PRE-CREATION
> third_party/libprocess/include/process/future.hpp 52d1679
> third_party/libprocess/include/process/gc.hpp d9ccb35
> third_party/libprocess/include/process/latch.hpp 1f04da4
> third_party/libprocess/include/process/message.hpp PRE-CREATION
> third_party/libprocess/include/process/process.hpp b7d1a86
> third_party/libprocess/include/process/protobuf.hpp 7636822
> third_party/libprocess/include/process/run.hpp 6787f6d
> third_party/libprocess/include/process/timeout.hpp 96905a8
> third_party/libprocess/include/process/timer.hpp a9706aa
> third_party/libprocess/src/encoder.hpp 1432aec
> third_party/libprocess/src/foreach.hpp ae17f58
> third_party/libprocess/src/latch.cpp 1d53246
> third_party/libprocess/src/process.cpp d77b156
> third_party/libprocess/src/tests.cpp b3521f3
> third_party/libprocess/src/timer.cpp e9a081a
>
> Diff: https://reviews.apache.org/r/3061/diff
>
>
> Testing
> -------
>
> ./bin/tests/all-tests
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Updated libprocess (to work on Mac 10.7) and
corresponding Mesos changes.
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/#review3713
-----------------------------------------------------------
third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/3061/#comment8327>
pthread_create doesn't set errno.
- Charles
On 2011-12-07 19:06:41, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3061/
> -----------------------------------------------------------
>
> (Updated 2011-12-07 19:06:41)
>
>
> Review request for mesos and John Sirois.
>
>
> Summary
> -------
>
> This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
>
>
> This addresses bugs MESOS-32 and MESOS-36.
> https://issues.apache.org/jira/browse/MESOS-32
> https://issues.apache.org/jira/browse/MESOS-36
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33248ec
> include/mesos/scheduler.hpp 93dda98
> src/common/lock.hpp 2958752
> src/common/lock.cpp 1d2118a
> src/common/type_utils.hpp c0b5fe9
> src/exec/exec.cpp b27c241
> src/local/local.cpp 1e2273b
> src/log/log.cpp 7386a9d
> src/log/network.hpp c88822c
> src/log/replica.cpp e60f4df
> src/master/frameworks_manager.hpp bf97d5f
> src/master/frameworks_manager.cpp 30fa325
> src/master/http.cpp 47caf48
> src/master/master.hpp fdacf36
> src/master/master.cpp b6cfde7
> src/master/slaves_manager.cpp 3f67aa1
> src/python/native/mesos_executor_driver_impl.cpp ed4aaa5
> src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
> src/python/native/proxy_scheduler.cpp 934820a
> src/sched/sched.cpp 7f4e980
> src/slave/http.cpp 18efd8c
> src/slave/reaper.hpp 63b1f5d
> src/slave/reaper.cpp 4193692
> src/slave/slave.hpp 37bbd8c
> src/slave/slave.cpp de5716c
> src/tests/exception_tests.cpp 62f4fb6
> src/tests/fault_tolerance_tests.cpp ebb7709
> src/tests/log_tests.cpp c6bbdd1
> src/tests/master_tests.cpp 2438114
> src/tests/utils.hpp 02772f7
> src/zookeeper/zookeeper.cpp c1aa827
> third_party/libprocess/Makefile.in 6b9a095
> third_party/libprocess/include/process/async.hpp 9886c3e
> third_party/libprocess/include/process/dispatch.hpp 9e69896
> third_party/libprocess/include/process/event.hpp PRE-CREATION
> third_party/libprocess/include/process/future.hpp 52d1679
> third_party/libprocess/include/process/gc.hpp d9ccb35
> third_party/libprocess/include/process/latch.hpp 1f04da4
> third_party/libprocess/include/process/message.hpp PRE-CREATION
> third_party/libprocess/include/process/process.hpp b7d1a86
> third_party/libprocess/include/process/protobuf.hpp 7636822
> third_party/libprocess/include/process/run.hpp 6787f6d
> third_party/libprocess/include/process/timeout.hpp 96905a8
> third_party/libprocess/include/process/timer.hpp a9706aa
> third_party/libprocess/src/encoder.hpp 1432aec
> third_party/libprocess/src/foreach.hpp ae17f58
> third_party/libprocess/src/latch.cpp 1d53246
> third_party/libprocess/src/process.cpp d77b156
> third_party/libprocess/src/tests.cpp b3521f3
> third_party/libprocess/src/timer.cpp e9a081a
>
> Diff: https://reviews.apache.org/r/3061/diff
>
>
> Testing
> -------
>
> ./bin/tests/all-tests
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Updated libprocess (to work on Mac 10.7) and
corresponding Mesos changes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3061/
-----------------------------------------------------------
(Updated 2011-12-07 19:06:41.983868)
Review request for mesos and John Sirois.
Changes
-------
Added the Python race bug number in here as well since it needed to get fixed in order to get the tests to pass.
Summary
-------
This is my first stab at the updated libprocess and corresponding Mesos changes. I'll probably go through a few iterations here (even without review feedback, just by looking at it myself).
This addresses bugs MESOS-32 and MESOS-36.
https://issues.apache.org/jira/browse/MESOS-32
https://issues.apache.org/jira/browse/MESOS-36
Diffs
-----
include/mesos/mesos.proto 33248ec
include/mesos/scheduler.hpp 93dda98
src/common/lock.hpp 2958752
src/common/lock.cpp 1d2118a
src/common/type_utils.hpp c0b5fe9
src/exec/exec.cpp b27c241
src/local/local.cpp 1e2273b
src/log/log.cpp 7386a9d
src/log/network.hpp c88822c
src/log/replica.cpp e60f4df
src/master/frameworks_manager.hpp bf97d5f
src/master/frameworks_manager.cpp 30fa325
src/master/http.cpp 47caf48
src/master/master.hpp fdacf36
src/master/master.cpp b6cfde7
src/master/slaves_manager.cpp 3f67aa1
src/python/native/mesos_executor_driver_impl.cpp ed4aaa5
src/python/native/mesos_scheduler_driver_impl.cpp 4bde768
src/python/native/proxy_scheduler.cpp 934820a
src/sched/sched.cpp 7f4e980
src/slave/http.cpp 18efd8c
src/slave/reaper.hpp 63b1f5d
src/slave/reaper.cpp 4193692
src/slave/slave.hpp 37bbd8c
src/slave/slave.cpp de5716c
src/tests/exception_tests.cpp 62f4fb6
src/tests/fault_tolerance_tests.cpp ebb7709
src/tests/log_tests.cpp c6bbdd1
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
src/zookeeper/zookeeper.cpp c1aa827
third_party/libprocess/Makefile.in 6b9a095
third_party/libprocess/include/process/async.hpp 9886c3e
third_party/libprocess/include/process/dispatch.hpp 9e69896
third_party/libprocess/include/process/event.hpp PRE-CREATION
third_party/libprocess/include/process/future.hpp 52d1679
third_party/libprocess/include/process/gc.hpp d9ccb35
third_party/libprocess/include/process/latch.hpp 1f04da4
third_party/libprocess/include/process/message.hpp PRE-CREATION
third_party/libprocess/include/process/process.hpp b7d1a86
third_party/libprocess/include/process/protobuf.hpp 7636822
third_party/libprocess/include/process/run.hpp 6787f6d
third_party/libprocess/include/process/timeout.hpp 96905a8
third_party/libprocess/include/process/timer.hpp a9706aa
third_party/libprocess/src/encoder.hpp 1432aec
third_party/libprocess/src/foreach.hpp ae17f58
third_party/libprocess/src/latch.cpp 1d53246
third_party/libprocess/src/process.cpp d77b156
third_party/libprocess/src/tests.cpp b3521f3
third_party/libprocess/src/timer.cpp e9a081a
Diff: https://reviews.apache.org/r/3061/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Benjamin