You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/06/03 21:04:00 UTC
[jira] [Commented] (IGNITE-13015) Use nano time in node failure
detection.
[ https://issues.apache.org/jira/browse/IGNITE-13015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125318#comment-17125318 ]
Ignite TC Bot commented on IGNITE-13015:
----------------------------------------
{panel:title=Branch: [pull/7872/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5346003&buildTypeId=IgniteTests24Java8_RunAll]
> Use nano time in node failure detection.
> ----------------------------------------
>
> Key: IGNITE-13015
> URL: https://issues.apache.org/jira/browse/IGNITE-13015
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Minor
> Labels: iep-45
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Make sure node failure detection do not use:
> {code:java}
> System.currentTimeMillis()
> and
> IgniteUtils.currentTimeMillis()
> {code}
> We should use nano time instead. Disadventages of current impl.:
> 1) System time has no quarantine of strict forward movement. System time can be adjusted, synchronized by NTP as example. This can lead to incorrect and negative delays.
> 2) IgniteUtils.currentTimeMillis() is granulated by 10ms
> *To fix*:
> {code:java}ServerImpl.lastRingMsgReceivedTime{code} should be nano.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)