You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2016/01/04 21:58:23 UTC

[GitHub] spark pull request: [SPARK-12438][SQL] Add SQLUserDefinedType supp...

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10390#discussion_r48780302
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
    @@ -94,6 +99,9 @@ class UserDefinedTypeSuite extends QueryTest with SharedSQLContext with ParquetT
         assert(featuresArrays.contains(new MyDenseVector(Array(0.2, 2.0))))
       }
     
    +  private val outers: ConcurrentMap[String, AnyRef] = new MapMaker().weakValues().makeMap()
    +  outers.put(getClass.getName, this)
    +
    --- End diff --
    
    These changes are not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org