[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug

[GitBox <gi...@apache.org>]

qiaozhanwei commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r361069044
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java
 ##########
 @@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){
     public Boolean submitWaitComplete() {
         Boolean result = false;
         this.taskInstance = submit();
+        if(this.taskInstance == null){
+            return result;
 
 Review comment:
   1，Uncertain return, it is recommended to debug
   2，submit failed should be logs and mail 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services