[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16301: Fix task retries when they receive sigkill and have retries. Properly handle sigterm too

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #16301:
URL: https://github.com/apache/airflow/pull/16301#discussion_r647443889



##########
File path: airflow/jobs/local_task_job.py
##########
@@ -156,7 +150,7 @@ def handle_task_exit(self, return_code: int) -> None:
         if self.task_instance.state == State.RUNNING:
             # This is for a case where the task received a sigkill
             # while running
-            self.task_instance.set_state(State.FAILED)
+            self.task_instance.handle_failure(error="Task received a SIGKILL signal")

Review comment:
       ```suggestion
               self.task_instance.handle_failure(error="Task received termination signal")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org