You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/04 01:35:15 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8748: [fix] Fixing time controls when switching datasource types

john-bodley opened a new pull request #8748: [fix] Fixing time controls when switching datasource types
URL: https://github.com/apache/incubator-superset/pull/8748
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR updates the temporal controls when switching datasource types in explorer which were missing as the Druid connector and SQLAlchemy connector have different fields. When we set the datasource upon change we also need to update the controls (indirectly via the form-data) leveraging the state changes.
   
   Thanks @graceguo-supercat for all the help, I would have been completely lost without you. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   ![Screen Shot 2019-12-03 at 5 26 59 PM](https://user-images.githubusercontent.com/4567245/70104370-a0aa3680-15f2-11ea-801c-c972e3faa50b.png)
   
   #### After 
   
   ![Screen Shot 2019-12-03 at 5 25 12 PM](https://user-images.githubusercontent.com/4567245/70104382-aacc3500-15f2-11ea-9110-1ea07d67ae23.png)
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @betodealmeida @etr2460 @graceguo-supercat @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org