[GitHub] flink pull request #5320: [FLINK-8355][table] remove DataSetAggregateWithNul...

[sunjincheng121 <gi...@git.apache.org>]

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/5320

    [FLINK-8355][table] remove DataSetAggregateWithNullValuesRule.

    *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
    
    ## What is the purpose of the change
    
    *(Remove DataSetAggregateWithNullValuesRule,DataSet Should not union a NULL row for AGG without GROUP BY clause..)*
    
    
    ## Brief change log
      - *Add interface for `DataSetAggFunction`, and in non-grouped non-pre agg emits a single result row with all aggregates at initialized state.*
      - *Change some test case.*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
      - *Add `testAggregateEmptyDataSets` in `AggregateITCase`*
      - *Change some plan check test case.*
      
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: ( no )
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? ( no)
      

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-8355-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5320
    
----
commit e8c0b10189910cc14ffcce0dabe0ac5eb32e4396
Author: 金竹 <ji...@...>
Date:   2018-01-03T15:13:49Z

    [FLINK-8325][table] Add COUNT(*),COUNT(1) supported

commit fe1b50bb095ee528b280a2a16b46dffa83b7e13d
Author: sunjincheng121 <su...@...>
Date:   2018-01-06T16:15:02Z

    Add SUM(2) supported in OVER window.

commit 585bb2f152bedd1fdce68d62841e596a345c8d26
Author: sunjincheng121 <su...@...>
Date:   2018-01-09T15:00:22Z

    improve code arroding feedback

commit 956a956608701fada55b56c69e675555fee6a45b
Author: sunjincheng121 <su...@...>
Date:   2018-01-15T00:07:34Z

    Fix non-merged aggregate bug [FlINK-8355]

commit 4ae9b65e6e90afa99fcab13ff67c3540ef767d72
Author: sunjincheng121 <su...@...>
Date:   2018-01-19T18:00:41Z

    improve the code

----


---

[GitHub] flink pull request #5320: [FLINK-8355][table] remove DataSetAggregateWithNul...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5320


---

[GitHub] flink issue #5320: [FLINK-8355][table] remove DataSetAggregateWithNullValues...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5320
  
    Thanks for the PR @sunjincheng121.
    It looks very good. I'll run final tests and will merge it.
    
    Fabian


---