You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2024/09/11 11:43:13 UTC
[PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
ashishkumar50 opened a new pull request, #7184:
URL: https://github.com/apache/ozone/pull/7184
## What changes were proposed in this pull request?
Remove extra log which is added in [HDDS-11342](https://issues.apache.org/jira/browse/HDDS-11342) for each fs operation.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11449
## How was this patch tested?
Verified using local docker cluster new log doesn't comes up for fs operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang merged PR #7184:
URL: https://github.com/apache/ozone/pull/7184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on code in PR #7184:
URL: https://github.com/apache/ozone/pull/7184#discussion_r1755258909
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java:
##########
@@ -317,9 +317,6 @@ public static boolean canEnableHsync(ConfigurationSource conf, boolean isClient)
if (confHBaseEnhancementsAllowed) {
return confHsyncEnabled;
} else {
- LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To enable it, set {} = true as well.",
- OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
- confKey);
return false;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #7184:
URL: https://github.com/apache/ozone/pull/7184#discussion_r1755233811
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java:
##########
@@ -317,9 +317,6 @@ public static boolean canEnableHsync(ConfigurationSource conf, boolean isClient)
if (confHBaseEnhancementsAllowed) {
return confHsyncEnabled;
} else {
- LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To enable it, set {} = true as well.",
- OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
- confKey);
return false;
Review Comment:
ah I see the mistake I made in the previous jira. Let's do this instead. This was there for a reason as I mentioned above. But I missed the extra check.
```suggestion
if (confHsyncEnabled) {
LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To enable it, set {} = true as well.",
OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
confKey);
}
return false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #7184:
URL: https://github.com/apache/ozone/pull/7184#discussion_r1755252726
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java:
##########
@@ -317,9 +317,6 @@ public static boolean canEnableHsync(ConfigurationSource conf, boolean isClient)
if (confHBaseEnhancementsAllowed) {
return confHsyncEnabled;
} else {
- LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To enable it, set {} = true as well.",
- OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
- confKey);
return false;
Review Comment:
The check can also become:
```java
if (confHBaseEnhancementsAllowed) {
return confHsyncEnabled;
} else if (confHsyncEnabled) {
LOG.warn("Ignoring {} = {} because HBase enhancements are disallowed. To enable it, set {} = true as well.",
OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, confHsyncEnabled,
confKey);
}
return false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #7184:
URL: https://github.com/apache/ozone/pull/7184#issuecomment-2344291097
-1.
This is intentionally WARN because the user will think that hsync is enabled because they set `ozone.fs.hsync.enabled` to `true`.
If you remove this, it will be SILENTLY disabled without warning. Then users/apps will complain that they don't get the desired behavior.
The correct thing to do is to disable hsync on the client as well by setting `ozone.fs.hsync.enabled` to `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11449. Remove unnecessary log from client console. [ozone]
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on PR #7184:
URL: https://github.com/apache/ozone/pull/7184#issuecomment-2344311250
Yes even if `ozone.fs.hsync.enabled` was false, the log is printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org