You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 13:06:43 UTC
[GitHub] [superset] andreas-eberle opened a new pull request #13730: refactor: helm chart: Use stringData instead of data in Secrets and remove manual base64 encoding
andreas-eberle opened a new pull request #13730:
URL: https://github.com/apache/superset/pull/13730
### SUMMARY
This PR switches to using Kubernetes' stringData field for Secrets instead of the data field. The benefits are:
* we can avoid the manual base64 encoding of every field
* when templating the helm chart, you can actually read the secrets and therefore better validate the generated template (e.g. injected config values).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #13730: refactor: helm chart: Use stringData instead of data in Secrets and remove manual base64 encoding
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #13730:
URL: https://github.com/apache/superset/pull/13730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andreas-eberle commented on pull request #13730: refactor: helm chart: Use stringData instead of data in Secrets and remove manual base64 encoding
Posted by GitBox <gi...@apache.org>.
andreas-eberle commented on pull request #13730:
URL: https://github.com/apache/superset/pull/13730#issuecomment-804778787
Thanks @craig-rueda for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org