You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Carsten Ziegeler <cz...@apache.org> on 2008/06/04 14:51:58 UTC
Several issues with generated notice files
Hi,
I just started to look at the new notice files and found several
problems, so I reopened the bug and added the info there.
I really think we should go back to hand written notice files, let's use
the now generated once as a starting point.
In addition I think we can remove the first blank line and the
"Apache...", so instead of:
----
Apache Sling - Thread Support
Apache Sling
Copyright 2008 The Apache Software Foundation
----
we just write:
----
Apache Sling - Thread Support
Copyright 2008 The Apache Software Foundation
----
Another issue is that now all notices files have the "based on Day
Software" stuff in it. While this is true for most of our modules, it's
not for all.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Several issues with generated notice files
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Jun 4, 2008 at 3:33 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ...For instance maven thinks that there is a mx4j inclusion in the scheduler.
> But it is definitly not, mx4j is used by quartz at compile time, but it's
> neither used at runtime nor is it distributed by us....
I'm fine if you want to fix those by hand, but please note that in
SLING-495 so that we can to back if needed.
-Bertrand
Re: Several issues with generated notice files
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Wed, Jun 4, 2008 at 2:51 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> ...I just started to look at the new notice files and found several problems,
>> so I reopened the bug and added the info there...
>
> See my comments in SLING-495 - I think the current state reflects Roy's changes.
>
>> ... I really think we should go back to hand written notice files, let's use the
>> now generated once as a starting point....
>
> If we do this, we lose the benefit of detecting when new dependencies
> are introduced by Maven, for future releases. This means going back to
> 100% manual maintenance of our 55 (currently) NOTICE files...not nice
> if we can avoid it.
>
Given the problems we have I'm not sure what the best solution is.
Dependencies do not just
change and checking what you might get before you change a dependency is
a good thing :)
For instance maven thinks that there is a mx4j inclusion in the
scheduler. But it is definitly not, mx4j is used by quartz at compile
time, but it's neither used at runtime nor is it distributed by us.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Several issues with generated notice files
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> On Wed, Jun 4, 2008 at 3:30 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>> Bertrand Delacretaz wrote:
>>> Easy - just remove the first line of etc/notice/notices/prefix.txt.
>>> For now I left it because I think that's what Roy intendend, i.e. that
>>> Apache Sling as a whole is copyright ASF.
>>>
>> Hmm, ok, might make sense...
>
> I suggest that we keep this for now, it just looks a bit weird, not problematic.
>
>>> ...Or (better IMHO), we can modify the note in prefix.txt (which shows at
>>> the beginning of all generated NOTICEs) to say something like "The
>>> Apache Sling project is based on code initially provided by Day
>>> Software", which is more generic and true.
>>>
>> Yes, I think that's more appropriate...
>
> Ok, I'll do that right now.
>
>> ...This notice issue is really becoming very annoying. For instance the mention
>> of slf4j or quartz in the notice files is done in many other projects and I
>> thought that we have to give them attribution if we include their stuff.
>> Now, Roy removed these. I'm clueless what's right, sorry....
>
> I suggest that we trust Roy on this for now.
>
I trust Roy, but I know that other projects would definitly vote against
such a notice file. And this is the strange point here.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Several issues with generated notice files
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Jun 4, 2008 at 3:30 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> Bertrand Delacretaz wrote:
>>
>> Easy - just remove the first line of etc/notice/notices/prefix.txt.
>> For now I left it because I think that's what Roy intendend, i.e. that
>> Apache Sling as a whole is copyright ASF.
>>
> Hmm, ok, might make sense...
I suggest that we keep this for now, it just looks a bit weird, not problematic.
>> ...Or (better IMHO), we can modify the note in prefix.txt (which shows at
>> the beginning of all generated NOTICEs) to say something like "The
>> Apache Sling project is based on code initially provided by Day
>> Software", which is more generic and true.
>>
> Yes, I think that's more appropriate...
Ok, I'll do that right now.
> ...This notice issue is really becoming very annoying. For instance the mention
> of slf4j or quartz in the notice files is done in many other projects and I
> thought that we have to give them attribution if we include their stuff.
> Now, Roy removed these. I'm clueless what's right, sorry....
I suggest that we trust Roy on this for now.
-Bertrand
Re: Several issues with generated notice files
Posted by Carsten Ziegeler <cz...@apache.org>.
Bertrand Delacretaz wrote:
> Easy - just remove the first line of etc/notice/notices/prefix.txt.
> For now I left it because I think that's what Roy intendend, i.e. that
> Apache Sling as a whole is copyright ASF.
>
Hmm, ok, might make sense.
>> ----
>> ...Another issue is that now all notices files have the "based on Day Software"
>> stuff in it. While this is true for most of our modules, it's not for all....
>
> Easy to fix with a fake "day-based" dependency for those modules where
> it's the case, declared in
>
> Or (better IMHO), we can modify the note in prefix.txt (which shows at
> the beginning of all generated NOTICEs) to say something like "The
> Apache Sling project is based on code initially provided by Day
> Software", which is more generic and true.
>
Yes, I think that's more appropriate.
This notice issue is really becoming very annoying. For instance the
mention of slf4j or quartz in the notice files is done in many other
projects and I thought that we have to give them attribution if we
include their stuff. Now, Roy removed these. I'm clueless what's right,
sorry.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Several issues with generated notice files
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Jun 4, 2008 at 2:51 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> ...I just started to look at the new notice files and found several problems,
> so I reopened the bug and added the info there...
See my comments in SLING-495 - I think the current state reflects Roy's changes.
>... I really think we should go back to hand written notice files, let's use the
> now generated once as a starting point....
If we do this, we lose the benefit of detecting when new dependencies
are introduced by Maven, for future releases. This means going back to
100% manual maintenance of our 55 (currently) NOTICE files...not nice
if we can avoid it.
If you need to make manual changes before the release, please do them
all in one commit, and note the revision number in SLING-495, so that
we can have a diff of those manual changes.
> ...In addition I think we can remove the first blank line and the "Apache...",
> so instead of:
> ----
> Apache Sling - Thread Support
>
> Apache Sling
> Copyright 2008 The Apache Software Foundation
> ----
>
> we just write:
> ----
> Apache Sling - Thread Support
> Copyright 2008 The Apache Software Foundation
Easy - just remove the first line of etc/notice/notices/prefix.txt.
For now I left it because I think that's what Roy intendend, i.e. that
Apache Sling as a whole is copyright ASF.
> ----
> ...Another issue is that now all notices files have the "based on Day Software"
> stuff in it. While this is true for most of our modules, it's not for all....
Easy to fix with a fake "day-based" dependency for those modules where
it's the case, declared in
Or (better IMHO), we can modify the note in prefix.txt (which shows at
the beginning of all generated NOTICEs) to say something like "The
Apache Sling project is based on code initially provided by Day
Software", which is more generic and true.
-Bertrand