[GitHub] [buildstream] adoakley commented on issue #1690: buildstream goes into the background after entering a shell

[GitBox <gi...@apache.org>]

adoakley commented on issue #1690:
URL: https://github.com/apache/buildstream/issues/1690#issuecomment-1293472229

   What's happening here is that the shell ends up in it's own process group, and calls `tcsetpgrp` in order to make it the terminal foreground process group.  When the shell exits nothing makes buildbox the foreground process group again (shells typically have code to do this, but it can't work inside the pid namespace).  Buildbox attempts to read from the terminal while it's not the foreground process group and gets a `SIGTTIN` from the kernel.  This signal stops the process.
   
   This issue was previously fixed by change 8f401127c450ea1c2a1e2878d2ac28a7166d355c, but that code has been removed in favor of buildbox-run.
   
   The code to fix this seems fairly simple, but I'm not sure where the best place for it is - buildstream, buildbox, or bubblewrap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org