You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/21 20:23:56 UTC

[GitHub] markusthoemmes commented on a change in pull request #3798: Allow for activation store to accept user and request information

markusthoemmes commented on a change in pull request #3798: Allow for activation store to accept user and request information
URL: https://github.com/apache/incubator-openwhisk/pull/3798#discussion_r197265513
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/ActivationStore.scala
 ##########
 @@ -48,7 +49,8 @@ trait ActivationStore {
    * @param transid transaction ID for request
    * @return Future containing the retrieved WhiskActivation
    */
-  def get(activationId: ActivationId)(implicit transid: TransactionId): Future[WhiskActivation]
+  def get(activationId: ActivationId, user: Option[Identity] = None, request: Option[HttpRequest] = None)(
 
 Review comment:
   Why make `user` and `request` an Option? When would you not pass these values?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services