[GitHub] [incubator-doris] morningman commented on a change in pull request #3934: [Refactor] Replace some boost to std in OlapScanNode

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3934:
URL: https://github.com/apache/incubator-doris/pull/3934#discussion_r445999465



##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -186,9 +185,9 @@ Status OlapScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo
 
     // check if Canceled.
     if (state->is_cancelled()) {
-        boost::unique_lock<boost::mutex> l(_row_batches_lock);
+        std::unique_lock<std::mutex> l(_row_batches_lock);

Review comment:
       This PR is only try to solve the BE crash problem and I don't want to introduce any new potential problems.
   I can't see any necessary to replace the `std::condition_variable` with `ConditionVariable`. If it is,
   maybe we can replace all `std::condition_variable` in another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org