[GitHub] [superset] rusackas commented on pull request #19429: fix(dashboard): make to filter the correct certified or non-certified…

[GitBox <gi...@apache.org>]

rusackas commented on PR #19429:
URL: https://github.com/apache/superset/pull/19429#issuecomment-1104397816

   > Thanks for fixing this issue. For the short term, the fix is good. for the long term, I suggest adding `todo` notation in the codebase. We might set the `certified_by` to `NULL` in the [Dashboard model](https://github.com/apache/superset/blob/a2d34ec4b8a89723e7468f194a98386699af0bd7/superset/models/dashboard.py#L145) when the user deactivates certified so that only keep `is null` in where clause.
   
   @prosdev0107 do you want to add that TODO as suggested?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org