You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ni...@apache.org on 2020/01/08 02:19:06 UTC

[kylin] branch master updated: Fix error judgment in PushDownExecutor.java

This is an automated email from the ASF dual-hosted git repository.

nic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/master by this push:
     new b3884a1  Fix error judgment in PushDownExecutor.java
b3884a1 is described below

commit b3884a11353a1a2ebabe0b9bed600b24110fe5eb
Author: yaqian.zhang <59...@qq.com>
AuthorDate: Tue Jan 7 17:35:31 2020 +0800

    Fix error judgment in PushDownExecutor.java
---
 .../src/main/java/org/apache/kylin/query/util/PushDownExecutor.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java b/query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java
index b4b08cd..f0cc630 100644
--- a/query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java
+++ b/query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java
@@ -58,9 +58,8 @@ public class PushDownExecutor {
     public Pair<List<List<String>>, List<SelectedColumnMeta>> pushDownQuery(String project,
             String sql, String defaultSchema, SQLException sqlException, boolean isSelect,
             boolean isPrepare) throws Exception {
-        List<String> ids = kylinConfig.getPushDownRunnerIds();
 
-        if (kylinConfig.isPushDownEnabled()) {
+        if (!kylinConfig.isPushDownEnabled()) {
             return null;
         }
 
@@ -75,6 +74,8 @@ public class PushDownExecutor {
             logger.info("Kylin cannot support non-select queries, routing to other engines");
         }
 
+        List<String> ids = kylinConfig.getPushDownRunnerIds();
+
         if (ids.isEmpty() && StringUtils.isNotEmpty(kylinConfig.getPushDownRunnerClassName())) {
             IPushDownRunner runner = (IPushDownRunner) ClassUtil.newInstance(
                     kylinConfig.getPushDownRunnerClassName()