You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2011/01/03 14:01:00 UTC
[jira] Created: (COUCHDB-1007) Removing no longer used options from
the ini configuration
Removing no longer used options from the ini configuration
----------------------------------------------------------
Key: COUCHDB-1007
URL: https://issues.apache.org/jira/browse/COUCHDB-1007
Project: CouchDB
Issue Type: Bug
Environment: trunk, 1.1.x
Reporter: Filipe Manana
Assignee: Filipe Manana
Priority: Trivial
We have some no longer used options in the .ini configuration.
I would like to simply drop them from trunk and 1.1.x
Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1007) Removing no longer used options from
the ini configuration
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-1007:
-----------------------------------
Attachment: COUCHDB-1007.patch
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1007) Removing no longer used options from
the ini configuration
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated COUCHDB-1007:
-----------------------------------
Fix Version/s: 1.2
1.1
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Fix For: 1.1, 1.2
>
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1007) Removing no longer used options
from the ini configuration
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976723#action_12976723 ]
Paul Joseph Davis commented on COUCHDB-1007:
--------------------------------------------
LGTM +1
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1007) Removing no longer used options
from the ini configuration
Posted by "Benoit Chesneau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976737#action_12976737 ]
Benoit Chesneau commented on COUCHDB-1007:
------------------------------------------
+1
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-1007) Removing no longer used options from
the ini configuration
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Randall Leeds updated COUCHDB-1007:
-----------------------------------
Attachment: COUCHDB-1007.patch
I'd like to propose an alternative patch.
The nodelay option is not documented in the .ini files, so I think it's *fairly* safe to remove it and replace with a more general option "extra_options". Parsed as an erlang term using couch_util:parse_term, this option allows to set any options allowed by mochiweb which for now includes nodelay, backlog and acceptor_pool_size.
If anyone has strong feelings for it, we can keep nodelay in case we're paranoid about changing that out from under people who have deployed it with "true".
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1007) Removing no longer used options
from the ini configuration
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976810#action_12976810 ]
Paul Joseph Davis commented on COUCHDB-1007:
--------------------------------------------
The extra options is nice but I think should be a separate patch instead of bundling them. Also, is the nodelay in 1.1? If not then we can just remove it. If it was then we should mark it as deprecated for 1.2 and remove it after that's released.
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1007) Removing no longer used options
from the ini configuration
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976813#action_12976813 ]
Filipe Manana commented on COUCHDB-1007:
----------------------------------------
Randall, the purpose of this patch is just to remove unused stuff, and not to add new options. COUCHDB-1008 seems more related to what you propose. Nevertheless it should go into a separate ticket/patch, just like Paul pointed out.
Also, the extra_options should be documented (e.g., what are all the options?)
I also prefer the nodelay options to be in socket_options, like COUCHDB-1008 proposes. This is relative of course.
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-1007) Removing no longer used options
from the ini configuration
Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976819#action_12976819 ]
Randall Leeds commented on COUCHDB-1007:
----------------------------------------
Yeah. You're totally right, I'll move this to 1008. Sorry for the noise.
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COUCHDB-1007) Removing no longer used options from
the ini configuration
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana closed COUCHDB-1007.
----------------------------------
Resolution: Fixed
Applied to trunk and branch 1.1.x
> Removing no longer used options from the ini configuration
> ----------------------------------------------------------
>
> Key: COUCHDB-1007
> URL: https://issues.apache.org/jira/browse/COUCHDB-1007
> Project: CouchDB
> Issue Type: Bug
> Environment: trunk, 1.1.x
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Fix For: 1.1, 1.2
>
> Attachments: COUCHDB-1007.patch, COUCHDB-1007.patch
>
>
> We have some no longer used options in the .ini configuration.
> I would like to simply drop them from trunk and 1.1.x
> Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.