[GitHub] [pulsar] codelipenghui commented on a change in pull request #14808: [fix][txn]: fix some exception handle in transaction buffer

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #14808:
URL: https://github.com/apache/pulsar/pull/14808#discussion_r833864314



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -342,7 +342,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) {
             }
         }).exceptionally(exception -> {
             log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName());

Review comment:
       ```suggestion
               log.error("Transaction {} abort on topic {}.", txnID.toString(), topic.getName(), exception.getCause());
   ```

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -296,7 +296,7 @@ public void addFailed(ManagedLedgerException exception, Object ctx) {
             }
         }).exceptionally(exception -> {
             log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception);

Review comment:
       ```suggestion
               log.error("Transaction {} commit on topic {}.", txnID.toString(), topic.getName(), exception.getCause());
   ```

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
##########
@@ -218,7 +218,7 @@ public void recoverExceptionally(Exception e) {
                 }
             }).exceptionally(exception -> {
                 log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception);

Review comment:
       ```suggestion
                   log.error("Topic {}: TransactionBuffer recover failed", this.topic.getName(), exception.getCause());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org