You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/30 13:58:29 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #11357: [chore](third_party) Fix compilation errors when building brpc
adonis0147 opened a new pull request, #11357:
URL: https://github.com/apache/doris/pull/11357
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Some issues are resolved in this pull request:
1. Currently, some compilation errors occur when build `brpc` statically. We should add `-fPIC` to the dependencies which are required by `brpc`.
2. `set -e` doesn't work for the command `"${BUILD_SYSTEM}" -j "${PARALLEL}" && "${BUILD_SYSTEM}" install`. The script will continue even though the command return a non-zero status.
3. The name of `vectorscan` doesn't match the `md5`.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [x] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11357: [chore](thirdparty) Build script doesn't interrupt when errors occur.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200401526
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200164562
CC @BiteTheDDDDt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200211328
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200366926
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200211331
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11357:
URL: https://github.com/apache/doris/pull/11357#issuecomment-1200221466
> LGTM BTW, #11353 is a part of this pr, but submit earlier, maybe we can this pr after #11353? just a advice.
Ok, #11353 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 closed pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
Posted by GitBox <gi...@apache.org>.
adonis0147 closed pull request #11357: [chore](thirdparty) Fix compilation errors when building brpc
URL: https://github.com/apache/doris/pull/11357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #11357: [chore](thirdparty) Build script doesn't interrupt when errors occur.
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #11357:
URL: https://github.com/apache/doris/pull/11357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org