You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/24 07:51:43 UTC

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #16125: julia: migrate build process to cmake

ChaiBapchya commented on a change in pull request #16125: julia: migrate build process to cmake
URL: https://github.com/apache/incubator-mxnet/pull/16125#discussion_r361093646
 
 

 ##########
 File path: julia/deps/build.jl
 ##########
 @@ -137,7 +138,7 @@ if !libmxnet_detected
 
     run(download_cmd(package_url, "mxnet.7z"))
     # this command will create the dir "usr\\lib"
-    run(`$exe7z e mxnet.7z *\\build\\* *\\lib\\* -y -ousr\\lib`)
+    run(`$exe7z e mxnet.7z "*\\build\\*" "*\\lib\\*" -y -ousr\\lib`) # TODO check it works on windows or not
 
 Review comment:
   Does this imply we "might" break cmake build for windows? Can't we check this on windows before merging PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services