You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by manjuapu <gi...@git.apache.org> on 2017/10/18 15:53:29 UTC

[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction

GitHub user manjuapu opened a pull request:

    https://github.com/apache/kafka-site/pull/100

    MINOR: Pinterest link correction

    @guozhangwang Pleas review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manjuapu/kafka-site asf-site

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka-site/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit c8b319c4cc3e6018bc973209876003785c7c4406
Author: Manjula Kumar <ma...@confluent.io>
Date:   2017-10-18T15:52:31Z

    MINOR: Pinterest link correction

----


---

[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction

Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on a diff in the pull request:

    https://github.com/apache/kafka-site/pull/100#discussion_r145538033
  
    --- Diff: 0110/streams/index.html ---
    @@ -111,23 +93,41 @@ <h3 class="stream__text">Streams API use cases</h3>
                </div>
                <div class="customer__grid">
                  <div class="customer__item streams_logo_grid streams__ny__grid">
    -               <a href="https://www.nytimes.com" target="_blank" class="grid__logo__link">
    +               <a href="https://medium.com/@Pinterest_Engineering/using-kafka-streams-api-for-predictive-budgeting-9f58d206c996" target="_blank" class="grid__logo__link">
    --- End diff --
    
    @guozhangwang I have link for all logos as well as link in the content.


---

[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:

    https://github.com/apache/kafka-site/pull/100#discussion_r145530925
  
    --- Diff: 0110/streams/index.html ---
    @@ -82,26 +82,8 @@ <h3 class="streams_intro">The easiest way to write mission-critical real-time ap
             <h3 class="stream__text">Streams API use cases</h3>
              <div class="customers__grid">
                <div class="customer__grid">
    -             <div class="customer__item  streams_logo_grid streams__line__grid">
    -               <a href="https://linecorp.com/" target="_blank" class="grid__logo__link">
    -                 <span class="grid__item__logo" style="background-image: url('/images/powered-by/line.svg');width:9rem"></span>
    -               </a>
    -                 <p class="grid__item__customer__description extra__space"><a href="https://engineering.linecorp.com/en/blog/detail/80" target="_blank">LINE uses Apache Kafka</a> as a central datahub for our services to communicate to one another. Hundreds of billions of messages are produced daily and are used to execute various business logic, threat detection, search indexing and data analysis. LINE leverages Kafka Streams to reliably transform and filter topics enabling sub topics consumers can efficiently consume, meanwhile retaining easy maintainability thanks to its sophisticated yet minimal code base.</p>
    -             </div>
    -           </div>
    -           <div class="customer__grid">
    -             <div class="customer__item  streams_logo_grid streams__zalando__grid">
    -               <a href="http://www.zalando.com" target="_blank" class="grid__logo__link">
    -                 <span class="grid__item__logo" style="background-image: url('/images/powered-by/zalando.jpg');"></span>
    -               </a>
    -               <p class="grid__item__customer__description extra__space">As the leading online fashion retailer in Europe, Zalando uses Kafka as an ESB (Enterprise Service Bus), which helps us in transitioning from a monolithic to a micro services architecture. Using Kafka for processing
    -                 <a href="https://kafka-summit.org/sessions/using-kstreams-ktables-calculate-real-time-domain-rankings/" target='blank'> event streams</a> enables our technical team to do near-real time business intelligence.
    -               </p>
    -             </div>
    -           </div>
    -           <div class="customer__grid">
                  <div class="customer__item streams_logo_grid streams__ny__grid">
    -               <a href="https://www.nytimes.com" target="_blank" class="grid__logo__link">
    +               <a href="https://www.confluent.io/blog/publishing-apache-kafka-new-york-times/" target="_blank" class="grid__logo__link">
    --- End diff --
    
    Maybe better to use this url instead as it is from the original nyt website?
    
    https://open.nytimes.com/publishing-with-apache-kafka-at-the-new-york-times-7f0e3b7d2077


---

[GitHub] kafka-site issue #100: MINOR: Pinterest link correction

Posted by manjuapu <gi...@git.apache.org>.
Github user manjuapu commented on the issue:

    https://github.com/apache/kafka-site/pull/100
  
    @guozhangwang I am working on arranging the logos on powered-by page. It is still work in progress in this PR.


---

[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka-site/pull/100


---

[GitHub] kafka-site issue #100: MINOR: Pinterest link correction

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on the issue:

    https://github.com/apache/kafka-site/pull/100
  
    LGTM. Merged to asf-site.


---

[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction

Posted by guozhangwang <gi...@git.apache.org>.
Github user guozhangwang commented on a diff in the pull request:

    https://github.com/apache/kafka-site/pull/100#discussion_r145531542
  
    --- Diff: 0110/streams/index.html ---
    @@ -111,23 +93,41 @@ <h3 class="stream__text">Streams API use cases</h3>
                </div>
                <div class="customer__grid">
                  <div class="customer__item streams_logo_grid streams__ny__grid">
    -               <a href="https://www.nytimes.com" target="_blank" class="grid__logo__link">
    +               <a href="https://medium.com/@Pinterest_Engineering/using-kafka-streams-api-for-predictive-budgeting-9f58d206c996" target="_blank" class="grid__logo__link">
    --- End diff --
    
    Hmm.. why we need to ref links for pinterest, with one for its logo and the content as well while for others we just use one ref link for the logo only?


---