You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/19 03:35:19 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4831: Misc
enhancements to the broker routing
codecov-io edited a comment on issue #4831: Misc enhancements to the broker routing
URL: https://github.com/apache/incubator-pinot/pull/4831#issuecomment-555272979
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=h1) Report
> Merging [#4831](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/85c7f5a2df96ca4a0b17be6e5c80b26cbe2fdb5c?src=pr&el=desc) will **increase** coverage by `20.37%`.
> The diff coverage is `90%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4831 +/- ##
=============================================
+ Coverage 36.91% 57.29% +20.37%
- Complexity 0 4 +4
=============================================
Files 1213 1213
Lines 65503 65503
Branches 9534 9534
=============================================
+ Hits 24181 37528 +13347
+ Misses 39129 25140 -13989
- Partials 2193 2835 +642
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/pinot/core/transport/QueryRouter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | `93.22% <ø> (+15.25%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/core/transport/AsyncQueryResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvQXN5bmNRdWVyeVJlc3BvbnNlLmphdmE=) | `96.87% <ø> (+21.87%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `100% <100%> (+24%)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/pinot/core/transport/ServerChannels.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyQ2hhbm5lbHMuamF2YQ==) | `100% <100%> (+3.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/pinot/core/transport/ServerResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyUmVzcG9uc2UuamF2YQ==) | `90.47% <75%> (+9.52%)` | `0 <0> (ø)` | :arrow_down: |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `32.05% <0%> (-48.72%)` | `0% <0%> (ø)` | |
| [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | |
| [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `44.08% <0%> (-8.61%)` | `0% <0%> (ø)` | |
| [...he/pinot/controller/util/SegmentIntervalUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlZ21lbnRJbnRlcnZhbFV0aWxzLmphdmE=) | `0% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `62.19% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [602 more](https://codecov.io/gh/apache/incubator-pinot/pull/4831/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=footer). Last update [85c7f5a...4967c0a](https://codecov.io/gh/apache/incubator-pinot/pull/4831?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org