You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/05/04 16:52:00 UTC

[jira] [Work logged] (ARTEMIS-4256) properties config - support removal

     [ https://issues.apache.org/jira/browse/ARTEMIS-4256?focusedWorklogId=860590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860590 ]

ASF GitHub Bot logged work on ARTEMIS-4256:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/23 16:51
            Start Date: 04/May/23 16:51
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #4466:
URL: https://github.com/apache/activemq-artemis/pull/4466#discussion_r1185268226


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/config/ActiveMQDefaultConfiguration.java:
##########
@@ -569,8 +569,12 @@ public static String getDefaultHapolicyBackupStrategy() {
 
    public static final String BROKER_PROPERTIES_KEY_SURROUND = "\"";
 
+   public static final String BROKER_PROPERTIES_REMOVE_VALUE = "-";

Review Comment:
   Other markup launguages as YAML use `~` for the null value, https://yaml.org/type/null.html





Issue Time Tracking
-------------------

            Worklog Id:     (was: 860590)
    Remaining Estimate: 0h
            Time Spent: 10m

> properties config - support removal
> -----------------------------------
>
>                 Key: ARTEMIS-4256
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4256
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, Configuration
>    Affects Versions: 2.28.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> broker properties allow addition and modification of configuration elements through property key=values but don't current allow an entry to be removed.
>  
> When used as part of configuration reload, being able to delete is useful!
> maybe a key value with some special value is the way to signal to remove that entry.
>  
> addressConfigurations.COMMANDS=-
> in this case the minus char  '-' means remove the address called COMMANDS
> =- seems nice, allowing the remove value to be configured by a property remove.value makes sense too in case - is a valid value.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)