You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/04/18 06:08:53 UTC
[GitHub] [hadoop] liuml07 commented on a change in pull request #1861:
HADOOP-13230. Optionally retain directory markers
liuml07 commented on a change in pull request #1861: HADOOP-13230. Optionally retain directory markers
URL: https://github.com/apache/hadoop/pull/1861#discussion_r410640648
##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/StatusProbeEnum.java
##########
@@ -33,28 +33,25 @@
/** LIST under the path. */
List;
- /** All probes. */
- public static final Set<StatusProbeEnum> ALL = EnumSet.allOf(
- StatusProbeEnum.class);
-
- /** Skip the HEAD and only look for directories. */
- public static final Set<StatusProbeEnum> DIRECTORIES =
- EnumSet.of(DirMarker, List);
-
- /** We only want the HEAD or dir marker. */
- public static final Set<StatusProbeEnum> HEAD_OR_DIR_MARKER =
- EnumSet.of(Head, DirMarker);
+ /** Look for files and directories. */
+ public static final Set<StatusProbeEnum> ALL =
+ EnumSet.of(Head, List);
/** We only want the HEAD. */
public static final Set<StatusProbeEnum> HEAD_ONLY =
EnumSet.of(Head);
- /** We only want the dir marker. */
- public static final Set<StatusProbeEnum> DIR_MARKER_ONLY =
- EnumSet.of(DirMarker);
-
- /** We only want the dir marker. */
+ /** List operation only. */
public static final Set<StatusProbeEnum> LIST_ONLY =
EnumSet.of(List);
+ /** Look for files and directories. */
+ public static final Set<StatusProbeEnum> FILE =
+ HEAD_ONLY;
+
+ /** Skip the HEAD and only look for directories. */
+ public static final Set<StatusProbeEnum> DIRECTORIES =
+ LIST_ONLY;
+
+
Review comment:
Do we still need `DirMarker` in the `StatusProbeEnum`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org