You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/03/11 02:32:09 UTC
Review Request 31923: RU - DB Schema differs between Postgres
internal and external
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31923/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Sid Wagle.
Bugs: AMBARI-10022
https://issues.apache.org/jira/browse/AMBARI-10022
Repository: ambari
Description
-------
The DB schema differs between the internal and external Postgres databases, and this affects RU.
Impact: If not fixed in Ambari 2.0, then a future release will have to absorb the technical debt and need the Ambari Update to correct the schema in order to keep it consistent in order to prevent bugs.
Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
```
CREATE TABLE ambari.repo_version (
repo_version_id BIGINT, -- should have NOT NULL modifier
...
INSERT INTO ambari_sequences (sequence_name, sequence_value)
...
union all
select 'upgrade_group_id_seq', 0
```
vs
Ambari-DDL-Postgres-CREATE.sql
```
CREATE TABLE ambari.repo_version (
repo_version_id BIGINT NOT NULL,
...
INSERT INTO ambari_sequences (sequence_name, sequence_value)
...
-- Doesn't insert upgrade_group_id_seq
```
Diffs
-----
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 034f871
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 488e268
Diff: https://reviews.apache.org/r/31923/diff/
Testing
-------
Unit tests are in progress.
Thanks,
Alejandro Fernandez
Re: Review Request 31923: RU - DB Schema differs between Postgres
internal and external
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31923/#review76067
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On March 10, 2015, 9:32 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31923/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-10022
> https://issues.apache.org/jira/browse/AMBARI-10022
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The DB schema differs between the internal and external Postgres databases, and this affects RU.
>
> Impact: If not fixed in Ambari 2.0, then a future release will have to absorb the technical debt and need the Ambari Update to correct the schema in order to keep it consistent in order to prevent bugs.
>
> Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT, -- should have NOT NULL modifier
>
> ...
>
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> union all
> select 'upgrade_group_id_seq', 0
> ```
>
> vs
>
> Ambari-DDL-Postgres-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT NOT NULL,
>
> ...
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> -- Doesn't insert upgrade_group_id_seq
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 034f871
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 488e268
>
> Diff: https://reviews.apache.org/r/31923/diff/
>
>
> Testing
> -------
>
> Unit tests are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 31923: RU - DB Schema differs between Postgres
internal and external
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31923/#review76060
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On March 10, 2015, 9:32 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31923/
> -----------------------------------------------------------
>
> (Updated March 10, 2015, 9:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-10022
> https://issues.apache.org/jira/browse/AMBARI-10022
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The DB schema differs between the internal and external Postgres databases, and this affects RU.
>
> Impact: If not fixed in Ambari 2.0, then a future release will have to absorb the technical debt and need the Ambari Update to correct the schema in order to keep it consistent in order to prevent bugs.
>
> Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT, -- should have NOT NULL modifier
>
> ...
>
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> union all
> select 'upgrade_group_id_seq', 0
> ```
>
> vs
>
> Ambari-DDL-Postgres-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT NOT NULL,
>
> ...
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> -- Doesn't insert upgrade_group_id_seq
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 034f871
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 488e268
>
> Diff: https://reviews.apache.org/r/31923/diff/
>
>
> Testing
> -------
>
> Unit tests are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 31923: RU - DB Schema differs between Postgres
internal and external
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31923/#review76071
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 11, 2015, 1:32 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31923/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 1:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-10022
> https://issues.apache.org/jira/browse/AMBARI-10022
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The DB schema differs between the internal and external Postgres databases, and this affects RU.
>
> Impact: If not fixed in Ambari 2.0, then a future release will have to absorb the technical debt and need the Ambari Update to correct the schema in order to keep it consistent in order to prevent bugs.
>
> Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT, -- should have NOT NULL modifier
>
> ...
>
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> union all
> select 'upgrade_group_id_seq', 0
> ```
>
> vs
>
> Ambari-DDL-Postgres-CREATE.sql
> ```
> CREATE TABLE ambari.repo_version (
> repo_version_id BIGINT NOT NULL,
>
> ...
>
> INSERT INTO ambari_sequences (sequence_name, sequence_value)
> ...
> -- Doesn't insert upgrade_group_id_seq
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 034f871
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 488e268
>
> Diff: https://reviews.apache.org/r/31923/diff/
>
>
> Testing
> -------
>
> Unit tests are in progress.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>